subject:"Re\: \[Cloud\-init\-dev\] \[Merge\] \~smoser\/cloud\-init\:bug\/1751051\-subp\-encode\-with\-utf8 into cloud\-init\:master"

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1751051-subp-encode-with-utf8 into cloud-init:master

2018-02-23 Thread Scott Moser

yeah, good catch. updated commit message and the comment also. -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/338586 Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:bug/1751051-subp-encode-with-utf8 into cloud-init:master.

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1751051-subp-encode-with-utf8 into cloud-init:master

2018-02-23 Thread Ryan Harper

Nifty test, and good change. The comment doesn't quite match the code; 'cloud-init will decode' should be 'cloud-init will encode' Right? -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/338586 Your team cloud-init commiters is requested to review the proposed merge

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1751051-subp-encode-with-utf8 into cloud-init:master

2018-02-22 Thread Server Team CI bot

Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:529ac9d19a1d73807efb956ae7de1ece9f51c0f9 https://jenkins.ubuntu.com/server/job/cloud-init-ci/781/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1751051-subp-encode-with-utf8 into cloud-init:master

2018-02-22 Thread Server Team CI bot

Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:927423ed11f3e2695384521a4ffe8c54df153a75 https://jenkins.ubuntu.com/server/job/cloud-init-ci/780/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild: