Re: Review Request: Have cloud-setup-* tools detect Debian

2013-02-24 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9310/#review17026 --- Applied on 4.1 and master as per Wido's ship it; 4.1: commit d5a47

Re: Review Request: Have cloud-setup-* tools detect Debian

2013-02-22 Thread Wido den Hollander
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9310/#review16937 --- Ship it! Ship It! - Wido den Hollander On Feb. 22, 2013, 10:36 a.

Re: Review Request: Have cloud-setup-* tools detect Debian

2013-02-22 Thread Rohit Yadav
> On Feb. 22, 2013, 10:39 a.m., Rohit Yadav wrote: > > No need to install lsb_release, for Ubuntu what can be done is to execute > > lsb_release -a and check the output if Distributor ID is Debian or Ubuntu Oh same for Debian :) - Rohit --

Re: Review Request: Have cloud-setup-* tools detect Debian

2013-02-22 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9310/#review16931 --- No need to install lsb_release, for Ubuntu what can be done is to exe

Re: Review Request: Have cloud-setup-* tools detect Debian

2013-02-22 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9310/ --- (Updated Feb. 22, 2013, 10:36 a.m.) Review request for cloudstack, Hugo Trippaer

RE: Review Request: Have cloud-setup-* tools detect Debian

2013-02-11 Thread Animesh Chaturvedi
Noa We keep the list of maintainers per component at https://cwiki.apache.org/confluence/display/CLOUDSTACK/Current+Maintainers+Per+Component. When submitting a patch you can look up that page to see who should be reviewing the patch Wido can you review the patch? Animesh > -Original Me