Re: [Cluster-devel] [PATCH] [GFS2] bz253089 Make gfs2_writepage use trylock on the log_flush lock

2007-09-14 Thread Steven Whitehouse
Hi, On Thu, 2007-09-13 at 11:36 -0500, Benjamin Marzinski wrote: > On Thu, Sep 13, 2007 at 11:30:37AM -0500, Benjamin Marzinski wrote: > > gfs2 was deadlocking because most code paths acquire the sd_log_flush_lock > > and > > then the page locks, while code paths going through gfs2_writepage acqu

Re: [Cluster-devel] [PATCH] [GFS2] bz 276631 : GFS2: chmod hung - TRY 3

2007-09-14 Thread Steven Whitehouse
Hi, Now in the -nmw git tree. Thanks, Steve. On Fri, 2007-09-14 at 09:27 -0500, Bob Peterson wrote: > This is a rewrite of the patch. We decided it was a better > approach to call separate wrapper functions than trying to work around > the problem with a spin_lock. > -- > The problem boiled dow

[Cluster-devel] [PATCH] [GFS2] bz 276631 : GFS2: chmod hung - TRY 3

2007-09-14 Thread Bob Peterson
This is a rewrite of the patch. We decided it was a better approach to call separate wrapper functions than trying to work around the problem with a spin_lock. -- The problem boiled down to a race between the gdlm_init_threads() function initializing thread1 and its setting of blist = 1. Essential

[Cluster-devel] cluster configure

2007-09-14 Thread teigland
CVSROOT:/cvs/cluster Module name:cluster Changes by: [EMAIL PROTECTED] 2007-09-14 14:32:04 Modified files: . : configure Log message: go back to default of -02 now that -Werror problems are fixed Patches: http://sourceware.org/cgi-bin/cvsweb.cg

Re: [Cluster-devel] [PATCH] [GFS2] bz 276631 : GFS2: chmod hung - TRY 2

2007-09-14 Thread David Teigland
On Thu, Sep 13, 2007 at 11:04:43PM -0500, Bob Peterson wrote: > diff -pur a/fs/gfs2/locking/dlm/thread.c b/fs/gfs2/locking/dlm/thread.c > --- a/fs/gfs2/locking/dlm/thread.c2007-09-13 17:33:58.0 -0500 > +++ b/fs/gfs2/locking/dlm/thread.c2007-09-13 22:47:14.0 -0500 > @@ -279,8

Re: [Cluster-devel] [PATCH] [GFS2] bz 276631 : GFS2: chmod hung - TRY 2

2007-09-14 Thread Steven Whitehouse
Hi, Now in the -nmw git tree. Thanks, Steve. On Thu, 2007-09-13 at 23:04 -0500, Bob Peterson wrote: > Josef's right--my bad. Here is the corrected patch for 276631. > > The problem boiled down to a race between the gdlm_init_threads() > function initializing thread1 and its setting of blist =

Re: [Cluster-devel] [PATCH] [DLM] bz#250464: Make dlm_sendd cond_resched more

2007-09-14 Thread Steven Whitehouse
Hi, On Fri, 2007-09-14 at 08:49 +0100, Patrick Caulfield wrote: > Under high recovery loads dlm_sendd can monopolise the CPU and cause soft > lockups. > > This one extra and one moved cond_resched() make it yield a little more during > such times keeping work moving. > > Signed-Off-By: Patrick

Re: [Cluster-devel] [PATCH GFS2] Move inode deletion out of blocking_cb

2007-09-14 Thread Steven Whitehouse
Hi, On Thu, 2007-09-13 at 17:52 -0400, Wendy Cheng wrote: > Move inode deletion code out of blocking_cb handle_callback route to > avoid racy conditions that end up blocking lock_dlm1 thread. Fix > bugzilla 286821. > > -- Wendy Now in the -nmw git tree. Thanks, Steve.

[Cluster-devel] Re: [PATCH][GFS2] - bz 272021: GFS2 - flocks from same process trip kernel BUG at fs/gfs2/glock.c:1118!

2007-09-14 Thread Steven Whitehouse
Hi, Now in the -nmw git tree. Thanks, Steve. On Thu, 2007-09-13 at 23:35 -0500, Abhijith Das wrote: > This patch adds a new flag to the gfs2_holder structure GL_FLOCK. > It is set on holders of glocks representing flocks. This flag is > checked in add_to_queue() and a process is permitted to q

[Cluster-devel] [PATCH] [DLM] bz#250464: Make dlm_sendd cond_resched more

2007-09-14 Thread Patrick Caulfield
Under high recovery loads dlm_sendd can monopolise the CPU and cause soft lockups. This one extra and one moved cond_resched() make it yield a little more during such times keeping work moving. Signed-Off-By: Patrick Caulfield <[EMAIL PROTECTED]> Patrick diff -wup linux-2.6.18.ia64/fs/dlm/lowco