[Cluster-devel] Re: [PATCH] fs/dlm/lowcomms.c: use ipv6_addr_copy

2009-01-22 Thread David Teigland
On Thu, Jan 22, 2009 at 01:24:49PM -0800, Joe Perches wrote: > Signed-off-by: Joe Perches > > diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c Thanks, added to next queue.

[Cluster-devel] conga/luci/site/luci/Extensions/ClusterModel M ...

2009-01-22 Thread rmccabe
CVSROOT:/cvs/cluster Module name:conga Branch: RHEL5 Changes by: rmcc...@sourceware.org 2009-01-22 21:31:41 Modified files: luci/site/luci/Extensions/ClusterModel: ModelBuilder.py QuorumD.py Log message: Fi

[Cluster-devel] [PATCH] fs/dlm/lowcomms.c: comment typo fixes

2009-01-22 Thread Joe Perches
Signed-off-by: Joe Perches diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c index 103a5eb..982314c 100644 --- a/fs/dlm/lowcomms.c +++ b/fs/dlm/lowcomms.c @@ -21,7 +21,7 @@ * * Cluster nodes are referred to by their nodeids. nodeids are * simply 32 bit numbers to the locking module - if th

[Cluster-devel] [PATCH] fs/dlm/lowcomms.c: use ipv6_addr_copy

2009-01-22 Thread Joe Perches
Signed-off-by: Joe Perches diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c index 103a5eb..982314c 100644 --- a/fs/dlm/lowcomms.c +++ b/fs/dlm/lowcomms.c @@ -53,6 +53,7 @@ #include #include #include +#include #include "dlm_internal.h" #include "lowcomms.h" @@ -250,8 +251,7 @@ static

[Cluster-devel] conga/luci/site/luci/Extensions/ClusterModel M ...

2009-01-22 Thread rmccabe
CVSROOT:/cvs/cluster Module name:conga Branch: RHEL5 Changes by: rmcc...@sourceware.org 2009-01-22 20:35:28 Modified files: luci/site/luci/Extensions/ClusterModel: ModelBuilder.py Log message: fix bz467464 Patches: http://sourceware.org/cgi-bin/cvsweb.cg

[Cluster-devel] Re: [PATCH 0/2] nfsd/dlm: fix knfsd panic when NFSv4 client does GETLK call

2009-01-22 Thread J. Bruce Fields
On Thu, Jan 22, 2009 at 02:16:02PM -0500, Jeff Layton wrote: > This patchset fixes a regression due to this patch: These look reasonable, thanks. My testing infrastructure and stuff is still down, so I may be a little slow getting these upstream Bug me again next week if I haven't done anythi

[Cluster-devel] [PATCH 1/2] dlm: initialize file_lock struct in GETLK before copying conflicting lock

2009-01-22 Thread Jeff Layton
dlm_posix_get fills out the relevant fields in the file_lock before returning when there is a lock conflict, but doesn't clean out any of the other fields in the file_lock. When nfsd does a NFSv4 lockt call, it sets the fl_lmops to nfsd_posix_mng_ops before calling the lower fs. When the lock come

[Cluster-devel] [PATCH 2/2] nfsd: only set file_lock.fl_lmops in nfsd4_lockt if a stateowner is found

2009-01-22 Thread Jeff Layton
nfsd4_lockt does a search for a lockstateowner when building the lock struct to test. If one is found, it'll set fl_owner to it. Regardless of whether that happens, it'll also set fl_lmops. Given that this lock is basically a "lightweight" lock that's just used for checking conflicts, setting fl_lm

[Cluster-devel] [PATCH 0/2] nfsd/dlm: fix knfsd panic when NFSv4 client does GETLK call

2009-01-22 Thread Jeff Layton
This patchset fixes a regression due to this patch: [snip] commit 55ef12744de387c54d110e354ffbb6cdc706 Author: J. Bruce Fields Date: Sat Dec 20 11:58:38 2008 -0800 nfsd: Ensure nfsv4 calls the underlying filesystem on LOCKT [snip]

[Cluster-devel] Re: [PATCH 2/2] nfsd: only set file_lock.fl_lmops in nfsd4_lockt if a stateowner is found

2009-01-22 Thread J. Bruce Fields
On Thu, Jan 22, 2009 at 02:09:02PM -0500, Jeff Layton wrote: > On Thu, 22 Jan 2009 13:59:30 -0500 > Jeff Layton wrote: > > > On Thu, 22 Jan 2009 13:52:32 -0500 > > "J. Bruce Fields" wrote: > > > > > On Wed, Jan 21, 2009 at 11:34:51AM -0500, Jeff Layton wrote: > > > > nfsd4_lockt does a search f

[Cluster-devel] Re: [PATCH 2/2] nfsd: only set file_lock.fl_lmops in nfsd4_lockt if a stateowner is found

2009-01-22 Thread J. Bruce Fields
On Thu, Jan 22, 2009 at 01:58:38PM -0500, Jeff Layton wrote: > On Thu, 22 Jan 2009 13:52:32 -0500 > "J. Bruce Fields" wrote: > > > On Wed, Jan 21, 2009 at 11:34:51AM -0500, Jeff Layton wrote: > > > nfsd4_lockt does a search for a lockstateowner when building the lock > > > struct to test. If one

[Cluster-devel] Re: [PATCH 2/2] nfsd: only set file_lock.fl_lmops in nfsd4_lockt if a stateowner is found

2009-01-22 Thread Jeff Layton
On Thu, 22 Jan 2009 13:59:30 -0500 Jeff Layton wrote: > On Thu, 22 Jan 2009 13:52:32 -0500 > "J. Bruce Fields" wrote: > > > On Wed, Jan 21, 2009 at 11:34:51AM -0500, Jeff Layton wrote: > > > nfsd4_lockt does a search for a lockstateowner when building the lock > > > struct to test. If one is fo

Re: [Cluster-devel] Re: [PATCH 1/2] dlm: initialize file_lock struct in GETLK before copying conflicting lock

2009-01-22 Thread David Teigland
On Thu, Jan 22, 2009 at 01:37:33PM -0500, Jeff Layton wrote: > > using locks_init_lock() plus the existing assignments. But, I think the > > best solution may be for dlm_posix_get() to set up a new lightweight > > file_lock with the values we need, and then call __locks_copy_lock() with > > it, ju

[Cluster-devel] Re: [PATCH 2/2] nfsd: only set file_lock.fl_lmops in nfsd4_lockt if a stateowner is found

2009-01-22 Thread Jeff Layton
On Thu, 22 Jan 2009 13:52:32 -0500 "J. Bruce Fields" wrote: > On Wed, Jan 21, 2009 at 11:34:51AM -0500, Jeff Layton wrote: > > nfsd4_lockt does a search for a lockstateowner when building the lock > > struct to test. If one is found, it'll set fl_owner to it. Regardless of > > whether that happen

[Cluster-devel] Re: [PATCH 2/2] nfsd: only set file_lock.fl_lmops in nfsd4_lockt if a stateowner is found

2009-01-22 Thread Jeff Layton
On Thu, 22 Jan 2009 13:52:32 -0500 "J. Bruce Fields" wrote: > On Wed, Jan 21, 2009 at 11:34:51AM -0500, Jeff Layton wrote: > > nfsd4_lockt does a search for a lockstateowner when building the lock > > struct to test. If one is found, it'll set fl_owner to it. Regardless of > > whether that happen

[Cluster-devel] Re: [PATCH 2/2] nfsd: only set file_lock.fl_lmops in nfsd4_lockt if a stateowner is found

2009-01-22 Thread J. Bruce Fields
On Wed, Jan 21, 2009 at 11:34:51AM -0500, Jeff Layton wrote: > nfsd4_lockt does a search for a lockstateowner when building the lock > struct to test. If one is found, it'll set fl_owner to it. Regardless of > whether that happens, it'll also set fl_lmops. > > If a lockstateowner is not found, the

Re: [Cluster-devel] Re: [PATCH 1/2] dlm: initialize file_lock struct in GETLK before copying conflicting lock

2009-01-22 Thread J. Bruce Fields
On Thu, Jan 22, 2009 at 12:05:43PM -0600, David Teigland wrote: > On Wed, Jan 21, 2009 at 06:42:39PM -0500, J. Bruce Fields wrote: > > On Wed, Jan 21, 2009 at 11:34:50AM -0500, Jeff Layton wrote: > > > dlm_posix_get fills out the relevant fields in the file_lock before > > > returning when there is

Re: [Cluster-devel] Re: [PATCH 1/2] dlm: initialize file_lock struct in GETLK before copying conflicting lock

2009-01-22 Thread Jeff Layton
On Thu, 22 Jan 2009 12:05:43 -0600 David Teigland wrote: > On Wed, Jan 21, 2009 at 06:42:39PM -0500, J. Bruce Fields wrote: > > On Wed, Jan 21, 2009 at 11:34:50AM -0500, Jeff Layton wrote: > > > dlm_posix_get fills out the relevant fields in the file_lock before > > > returning when there is a lo

[Cluster-devel] Re: [PATCH 1/2] dlm: initialize file_lock struct in GETLK before copying conflicting lock

2009-01-22 Thread Jeff Layton
On Thu, 22 Jan 2009 13:32:41 -0500 "J. Bruce Fields" wrote: > On Wed, Jan 21, 2009 at 09:26:08PM -0500, Jeff Layton wrote: > > On Wed, 21 Jan 2009 18:42:39 -0500 > > "J. Bruce Fields" wrote: > > > > > On Wed, Jan 21, 2009 at 11:34:50AM -0500, Jeff Layton wrote: > > > > dlm_posix_get fills out t

[Cluster-devel] Re: [PATCH 1/2] dlm: initialize file_lock struct in GETLK before copying conflicting lock

2009-01-22 Thread J. Bruce Fields
On Wed, Jan 21, 2009 at 09:26:08PM -0500, Jeff Layton wrote: > On Wed, 21 Jan 2009 18:42:39 -0500 > "J. Bruce Fields" wrote: > > > On Wed, Jan 21, 2009 at 11:34:50AM -0500, Jeff Layton wrote: > > > dlm_posix_get fills out the relevant fields in the file_lock before > > > returning when there is a

Re: [Cluster-devel] Re: [PATCH 1/2] dlm: initialize file_lock struct in GETLK before copying conflicting lock

2009-01-22 Thread David Teigland
On Wed, Jan 21, 2009 at 06:42:39PM -0500, J. Bruce Fields wrote: > On Wed, Jan 21, 2009 at 11:34:50AM -0500, Jeff Layton wrote: > > dlm_posix_get fills out the relevant fields in the file_lock before > > returning when there is a lock conflict, but doesn't clean out any of > > the other fields in t

[Cluster-devel] Cluster 2.03.11 released

2009-01-22 Thread Fabio M. Di Nitto
The cluster team and its vibrant community are proud to announce the 2.03.11 release from the STABLE2 branch. The STABLE2 branch collects, on a daily base, all bug fixes and the bare minimal changes required to run the cluster on top of the most recent Linux kernel (2.6.27) and rock solid openais