Re: [Cluster-devel] [PATCHv2 00/12]posix_acl: Add the check items

2009-12-21 Thread Christoph Hellwig
I like taking these checks into posix_acl_valid, but I think the patch submission needs a bit more work. All the patches are extremly whitespace mangled. And I don't think splitting them up makes a whole lot of sense, when we do API changes like this we usually fix up all callers. So please try

Re: [Cluster-devel] [PATCH 2/2] gfs2: Use CALLER_ADDR0 macro.

2009-12-21 Thread Christoph Hellwig
On Mon, Dec 21, 2009 at 09:22:41AM +, Steven Whitehouse wrote: Hi, Looks fairly harmless, even though I don't entirely see the point. Do you want me to add this to me tree? We also have a _RET_IP_ macro that does the same and has a much more useful name. And given that we need the

[Cluster-devel] GFS2: Fix gfs2_xattr_acl_chmod()

2009-12-21 Thread Steven Whitehouse
From a49cd198c9ed316255acc25a937ea147d03bccaa Mon Sep 17 00:00:00 2001 From: Steven Whitehouse swhit...@redhat.com Date: Mon, 21 Dec 2009 13:55:28 + Subject: GFS2: Fix gfs2_xattr_acl_chmod() The ref counting for the bh returned by gfs2_ea_find() was wrong. This patch ensures that we always