Re: [Cluster-devel] [PATCH 1/4] gfs2: add IO submission trace points

2010-02-05 Thread Steven Whitehouse
Hi, On Fri, 2010-02-05 at 16:45 +1100, Dave Chinner wrote: Useful for tracking down where specific IOs are being issued from. Signed-off-by: Dave Chinner dchin...@redhat.com --- fs/gfs2/log.c|6 ++ fs/gfs2/lops.c |6 ++ fs/gfs2/trace_gfs2.h | 41

Re: [Cluster-devel] [PATCH 1/4] gfs2: add IO submission trace points

2010-02-05 Thread Christoph Hellwig
On Fri, Feb 05, 2010 at 09:49:54AM +, Steven Whitehouse wrote: Hi, On Fri, 2010-02-05 at 16:45 +1100, Dave Chinner wrote: Useful for tracking down where specific IOs are being issued from. Signed-off-by: Dave Chinner dchin...@redhat.com --- fs/gfs2/log.c|6 ++

Re: [Cluster-devel] [PATCH 2/4] gfs2: ordered writes are backwards

2010-02-05 Thread Steven Whitehouse
Hi, This looks good. There is an argument for trying to sort the buffers as we write them (in case the application writes them out of order) but this seems a sensible change to catch 90% of cases. I'm just about to give this a quick test and I'll push this one in straight away if it looks good on

Re: [Cluster-devel] [PATCH 2/4] gfs2: ordered writes are backwards

2010-02-05 Thread Dave Chinner
On Fri, Feb 05, 2010 at 10:02:15AM +, Steven Whitehouse wrote: Hi, This looks good. There is an argument for trying to sort the buffers as we write them (in case the application writes them out of order) but this seems a sensible change to catch 90% of cases. Agreed. I'm taking small

Re: [Cluster-devel] [PATCH 3/4] gfs2: ordered buffer writes are not sync

2010-02-05 Thread Steven Whitehouse
Hi, On Fri, 2010-02-05 at 16:45 +1100, Dave Chinner wrote: Currently gfs2 ordered buffer writes use WRITE_SYNC_PLUG as the IO type being dispatched. They aren't sync writes; we issue all the IO pending, then wait for it all. IOWs, this is async IO with a bulk wait on the end. We should use

Re: [Cluster-devel] [PATCH 4/4] gfs2: introduce AIL lock

2010-02-05 Thread Steven Whitehouse
Hi, On Fri, 2010-02-05 at 16:45 +1100, Dave Chinner wrote: THe log lock is currently used to protect the AIL lists and the movements of buffers into and out of them. The lists are self contained and no log specific items outside the lists are accessed when starting or emptying the AIL lists.

[Cluster-devel] [GFS2 PATCH] - Bug 537201 - Better error reporting when mounting a gfs fs without enough journals

2010-02-05 Thread Abhijith Das
Hi, We need this one-liner to signal the mount helper of the 'insufficient journals' condition. Signed-off-by: Abhijith Das a...@redhat.com diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c index d405c38..a054b52 100644 --- a/fs/gfs2/ops_fstype.c +++ b/fs/gfs2/ops_fstype.c @@ -724,7

Re: [Cluster-devel] [GFS2 PATCH] - Bug 537201 - Better error reporting when mounting a gfs fs without enough journals

2010-02-05 Thread Abhijith Das
Please ignore the previous patch. The patch inlining didn't work right. Here's the unmangled one. --Abhi - Abhijith Das a...@redhat.com wrote: From: Abhijith Das a...@redhat.com To: cluster-devel cluster-devel@redhat.com Sent: Friday, February 5, 2010 5:17:56 PM GMT -06:00 US/Canada