Re: [Cluster-devel] [PATCH 2/2] dlm: Remove obsolete lockspace lookup

2010-02-18 Thread Steven Whitehouse
Hi, On Wed, 2010-02-17 at 15:12 -0500, David Teigland wrote: On Wed, Feb 17, 2010 at 09:41:35AM +, Steven Whitehouse wrote: We don't need to look up the lockspace in this particular case since we already have a pointer to it (which was being dereferenced in order to do the lookup in

Re: [Cluster-devel] dlm: Remove/bypass astd

2010-02-18 Thread Christine Caulfield
On 17/02/10 20:29, David Teigland wrote: On Wed, Feb 17, 2010 at 01:23:39PM +, Steven Whitehouse wrote: While investigating Red Hat bug #537010 I started looking at the dlm's astd thread. The way in which the cast and bast requests are queued looked as if it might cause reordering since

Re: [Cluster-devel] [PATCH 2/2] dlm: Remove obsolete lockspace lookup

2010-02-18 Thread David Teigland
On Thu, Feb 18, 2010 at 09:16:03AM +, Steven Whitehouse wrote: I'm not sure what more I can say here this is a sysfs file store function and one of the reasons for using it is that sysfs looks after the ref counting for you. Even aside from that, if you don't have a reference to the