Re: [Cluster-devel] [PATCH v2 0/2] gfs2: Stop using rhashtable_walk_peek

On Tue, Apr 03, 2018 at 01:41:26PM +1000, NeilBrown wrote: > > Do we really need a rhashtable_walk_peek() interface? > I imagine that a seqfile ->start function can do: > > if (*ppos == 0 && last_pos != 0) { > rhashtable_walk_exit(); > rhashtable_walk_enter(, ); > last_pos

Re: [Cluster-devel] [PATCH v2 0/2] gfs2: Stop using rhashtable_walk_peek

On Fri, Mar 30 2018, Herbert Xu wrote: > On Thu, Mar 29, 2018 at 06:52:34PM +0200, Andreas Gruenbacher wrote: >> >> Should rhashtable_walk_peek be kept around even if there are no more >> users? I have my doubts. > > Absolutely. All netlink dumps using rhashtable_walk_next are buggy > and need

Re: [Cluster-devel] [PATCH] dlm: prompt the user SCTP is experimental

Hi David, >>> > On Thu, Mar 22, 2018 at 10:27:56PM -0600, Gang He wrote: >> Hello David, >> >> Do you agree to add this prompt to the user? >> Since sometimes customers attempted to setup SCTP protocol with two rings, >> but they could not get the expected result, then it maybe bring some

[Cluster-devel] [PATCH 2/9] gfs2: Dirty source inode during rename

From: Andreas Gruenbacher Mark the source inode dirty during a rename instead of just updating the underlying buffer head. Otherwise, fsync may find the inode clean and will then skip flushing the journal. A subsequent power failure will cause the rename to be lost. This

[Cluster-devel] [PATCH 5/9] gfs2: Improve gfs2_block_map comment

From: Andreas Gruenbacher Signed-off-by: Andreas Gruenbacher Signed-off-by: Bob Peterson --- fs/gfs2/bmap.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c index

[Cluster-devel] [PATCH 9/9] gfs2: time journal recovery steps accurately

From: Abhi Das This patch spits out the time taken by the various steps in the journal recover process. Previously, the journal recovery time didn't account for finding the journal head in the log which takes up a significant portion of time. Signed-off-by: Abhi Das

[Cluster-devel] [PATCH 7/9] gfs2: Check for the end of metadata in punch_hole

From: Andreas Gruenbacher When punching a hole or truncating an inode down to a given size, also check if the truncate point / start of the hole is within the range we have metadata for. Otherwise, we can end up freeing blocks that shouldn't be freed, corrupting the inode,

[Cluster-devel] [PATCH 8/9] gfs2: Zero out fallocated blocks in fallocate_chunk

From: Andreas Gruenbacher Instead of zeroing out fallocated blocks in gfs2_iomap_alloc, zero them out in fallocate_chunk, much higher up the call stack. This gets rid of gfs2's abuse of the IOMAP_ZERO flag as well as the gfs2 specific zeronew buffer flag. I can't think of

[Cluster-devel] [PATCH 1/9] gfs2: Fix fallocate chunk size

From: Andreas Gruenbacher The chunk size of allocations in __gfs2_fallocate is calculated incorrectly. The size can collapse, causing __gfs2_fallocate to allocate one block at a time, which is very inefficient. This needs fixing in two places: In gfs2_quota_lock_check,

[Cluster-devel] [PATCH 0/9] GFS2: Pre-pull patch posting (merge window)

Hi, We've only got 9 GFS2 patches for this merge window: 1. Abhi Das contributed a patch to report journal recovery times more accurately during journal replay. 2. Andreas Gruenbacher contributed a patch to fix fallocate chunk size. 3. Andreas added a patch to correctly dirty inodes during

[Cluster-devel] [PATCH 4/9] GFS2: Only set PageChecked for jdata pages

Before this patch, GFS2 was setting the PageChecked flag for ordered write pages. This is unnecessary. The ext3 file system only does it for jdata, and it's only used in jdata circumstances. It only muddies the already murky waters of writing pages in the aops. Signed-off-by: Bob Peterson

[Cluster-devel] [PATCH 3/9] GFS2: Make function gfs2_remove_from_ail static

Function gfs2_remove_from_ail is only ever used from log.c, so there is no reason to declare it extern. This patch removes the extern and declares it static. Signed-off-by: Bob Peterson --- fs/gfs2/log.c | 2 +- fs/gfs2/log.h | 1 - 2 files changed, 1 insertion(+), 2

Re: [Cluster-devel] [PATCH] dlm: prompt the user SCTP is experimental

On Thu, Mar 22, 2018 at 10:27:56PM -0600, Gang He wrote: > Hello David, > > Do you agree to add this prompt to the user? > Since sometimes customers attempted to setup SCTP protocol with two rings, > but they could not get the expected result, then it maybe bring some concerns > to the