- Original Message -
> Hi,
>
> Occasionally during testing, we see the following assertion failure in
> log_pull_tail():
>
> [ 1104.061245] gfs2: fsid=xapi-clusterd:2d2cc24c-c48a-ca.0: fatal:
> assertion "atomic_read(>sd_log_blks_free) <=
> sdp->sd_jdesc->jd_blocks" failed
> [
Hi,
Occasionally during testing, we see the following assertion failure in
log_pull_tail():
[ 1104.061245] gfs2: fsid=xapi-clusterd:2d2cc24c-c48a-ca.0: fatal:
assertion "atomic_read(>sd_log_blks_free) <=
sdp->sd_jdesc->jd_blocks" failed
[ 1104.061245]function = log_pull_tail, file =
On 19/03/2019 17:05, David Howells wrote:
Andrew Price wrote:
+ pr_warn("-o debug and -o errors=panic are mutually
exclusive\n");
+ return -EINVAL;
return invalf(fc, "gfs2: -o debug and -o errors=panic are mutually exclusive");
Thanks.
Andrew Price wrote:
> + pr_warn("-o debug and -o errors=panic are mutually
> exclusive\n");
> + return -EINVAL;
return invalf(fc, "gfs2: -o debug and -o errors=panic are mutually exclusive");
(Note: no "\n")
> + if (result.int_32 > 0)
> +
Signed-off-by: Andrew Price
---
fs/gfs2/ops_fstype.c | 54 ++--
1 file changed, 32 insertions(+), 22 deletions(-)
diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
index ad2c98a37bd4..460d31403a7c 100644
--- a/fs/gfs2/ops_fstype.c
+++
These patches convert gfs2 and gfs2meta to use fs_context.
Tested with xfstests -g quick, a bunch of targeted mount commands to exercise
individual options, and gfs2_grow to test the gfs2meta mount.
v2: Use sget_fc() instead of sget()
Andrew Price (2):
gfs2: Convert gfs2 to fs_context
gfs2:
Switch to using fs_context ops for mount/remount.
Signed-off-by: Andrew Price
---
fs/gfs2/incore.h | 11 +-
fs/gfs2/ops_fstype.c | 405 ++-
fs/gfs2/super.c | 335 +--
fs/gfs2/super.h | 3 +-
4 files
On 18/03/2019 23:01, David Howells wrote:
Andrew Price wrote:
Umm... What about the fs_context struct? Why can't that be used to
propagate the bdev pointer? That's kind of what it's for...
It would be useful to have the block device pointer in the fs_context since so
many of the
