Re: [Cluster-devel] [PATCH v2.1 11/30] iomap: add the new iomap_iter model

2021-08-16 Thread Dave Chinner
On Wed, Aug 11, 2021 at 12:17:20PM -0700, Darrick J. Wong wrote: > From: Christoph Hellwig > > The iomap_iter struct provides a convenient way to package up and > maintain all the arguments to the various mapping and operation > functions. It is operated on using the iomap_iter() function that

Re: [Cluster-devel] [PATCH 31/30] iomap: move iomap iteration code to iter.c

2021-08-16 Thread Dave Chinner
On Wed, Aug 11, 2021 at 12:19:26PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Now that we've moved iomap to the iterator model, rename this file to be > in sync with the functions contained inside of it. > > Signed-off-by: Darrick J. Wong > --- > fs/iomap/Makefile |2 +- >

Re: [Cluster-devel] [PATCH v2.1 24/30] iomap: remove iomap_apply

2021-08-16 Thread Dave Chinner
On Wed, Aug 11, 2021 at 12:18:26PM -0700, Darrick J. Wong wrote: > From: Christoph Hellwig > > iomap_apply is unused now, so remove it. > > Signed-off-by: Christoph Hellwig > [djwong: rebase this patch to preserve git history of iomap loop control] > Reviewed-by: Darrick J. Wong >

Re: [Cluster-devel] [PATCH v2.1 19/30] iomap: switch iomap_bmap to use iomap_iter

2021-08-16 Thread Dave Chinner
On Wed, Aug 11, 2021 at 12:18:00PM -0700, Darrick J. Wong wrote: > From: Christoph Hellwig > > Rewrite the ->bmap implementation based on iomap_iter. > > Signed-off-by: Christoph Hellwig > [djwong: restructure the loop to make its behavior a little clearer] > Reviewed-by: Darrick J. Wong >

Re: [Cluster-devel] [PATCH v5 00/12] gfs2: Fix mmap + page fault deadlocks

2021-08-16 Thread Andreas Gruenbacher
On Tue, Aug 3, 2021 at 9:45 PM Linus Torvalds wrote: > On Tue, Aug 3, 2021 at 12:18 PM Andreas Gruenbacher > wrote: > > With this patch queue, fstest generic/208 (aio-dio-invalidate-failure.c) > > endlessly spins in gfs2_file_direct_write. It looks as if there's a bug > > in

Re: [Cluster-devel] Why does dlm_lock function fails when downconvert a dlm lock?

2021-08-16 Thread David Teigland
On Mon, Aug 16, 2021 at 09:41:18AM -0500, David Teigland wrote: > On Fri, Aug 13, 2021 at 02:49:04PM +0800, Gang He wrote: > > Hi David, > > > > On 2021/8/13 1:45, David Teigland wrote: > > > On Thu, Aug 12, 2021 at 01:44:53PM +0800, Gang He wrote: > > > > In fact, I can reproduce this problem

Re: [Cluster-devel] Why does dlm_lock function fails when downconvert a dlm lock?

2021-08-16 Thread David Teigland
On Fri, Aug 13, 2021 at 02:49:04PM +0800, Gang He wrote: > Hi David, > > On 2021/8/13 1:45, David Teigland wrote: > > On Thu, Aug 12, 2021 at 01:44:53PM +0800, Gang He wrote: > > > In fact, I can reproduce this problem stably. > > > I want to know if this error happen is by our expectation? since