Re: [Cluster-devel] [GFS2 PATCH 1/3] gfs2: switch go_xmote_bh glop to pass gh not gl

2021-08-24 Thread Andreas Gruenbacher
On Tue, Aug 24, 2021 at 6:48 PM Bob Peterson wrote: > On 8/24/21 11:12 AM, Andreas Gruenbacher wrote: > > On Tue, Aug 24, 2021 at 4:02 PM Bob Peterson wrote: > >> Before this patch, the go_xmote_bh function was passed gl, the glock > >> pointer. This patch switches it to gh, the holder, which

[Cluster-devel] [RFC v5.13.8] fs: dlm: fix srcu idx value per msg

2021-08-24 Thread Alexander Aring
This patch fixes an issue if new_wq_entry() returns the same writequeue entry and the idx field will be overwritten that was set by the previous call. We need to make the handle per call and store the srcu idx value there to avoid it. Fixes: 7ae861bbfa0f ("fs: dlm: fix srcu read lock usage")

Re: [Cluster-devel] FS/DLM module triggered kernel BUG

2021-08-24 Thread Alexander Aring
Hi Gang He, On Tue, Aug 24, 2021 at 10:18 AM Alexander Aring wrote: ... > > > > > >> [Fri Aug 20 16:24:14 2021] dlm: CEC5E19D749E473B99A0B792AD570441: > > >> generation 4 slots 2 1:172204786 2:172204748 > > >> [Fri Aug 20 16:24:14 2021] dlm: CEC5E19D749E473B99A0B792AD570441: > > >>

[Cluster-devel] [PATCH] gfs2: Fix broken freeze_go_xmote_bh

2021-08-24 Thread Bob Peterson
The freeze glock is used in several places whenever a gfs2 file system is frozen, thawed, mounted, unmounted, remounted, or withdrawn. It is used to prevent those things from clashing with one another. The freeze glock is sometimes held with a "live" journal (In other words SDF_JOURNAL_LIVE is

Re: [Cluster-devel] [GFS2 PATCH 1/3] gfs2: switch go_xmote_bh glop to pass gh not gl

2021-08-24 Thread Bob Peterson
Hi, On 8/24/21 11:12 AM, Andreas Gruenbacher wrote: On Tue, Aug 24, 2021 at 4:02 PM Bob Peterson wrote: Before this patch, the go_xmote_bh function was passed gl, the glock pointer. This patch switches it to gh, the holder, which points to the gl. This facilitates improvements for the next

Re: [Cluster-devel] [GFS2 PATCH 1/3] gfs2: switch go_xmote_bh glop to pass gh not gl

2021-08-24 Thread Andreas Gruenbacher
On Tue, Aug 24, 2021 at 4:02 PM Bob Peterson wrote: > Before this patch, the go_xmote_bh function was passed gl, the glock > pointer. This patch switches it to gh, the holder, which points to the gl. > This facilitates improvements for the next patch. > > Signed-off-by: Bob Peterson > --- >

Re: [Cluster-devel] [GFS2 PATCH 2/3] gfs2: Fix broken freeze_go_xmote_bh

2021-08-24 Thread Andreas Gruenbacher
On Tue, Aug 24, 2021 at 4:02 PM Bob Peterson wrote: > The freeze glock was used in several places whenever a gfs2 file system > was frozen, thawed, mounted, unmounted, remounted, or withdrawn. It was > used to prevent those things from clashing with one another. > Function freeze_go_xmote_bh

Re: [Cluster-devel] FS/DLM module triggered kernel BUG

2021-08-24 Thread Alexander Aring
Hi Gang He, On Tue, Aug 24, 2021 at 1:36 AM Gang He wrote: > > > > On 2021/8/23 21:49, Alexander Aring wrote: > > Hi Gang He, > > > > On Mon, Aug 23, 2021 at 1:43 AM Gang He wrote: > >> > >> Hello Guys, > >> > >> I used kernel 5.13.8, I sometimes encountered the dlm module triggered > >>

[Cluster-devel] [GFS2 PATCH 0/3] gfs2: Fix freeze/thaw journal check problems

2021-08-24 Thread Bob Peterson
This patch set fixes some problems in which the freeze glock's glop functions were not working as expected. Bob Peterson (3): gfs2: switch go_xmote_bh glop to pass gh not gl gfs2: Fix broken freeze_go_xmote_bh gfs2: Eliminate go_xmote_bh in favor of go_lock fs/gfs2/glock.c | 12

[Cluster-devel] [GFS2 PATCH 2/3] gfs2: Fix broken freeze_go_xmote_bh

2021-08-24 Thread Bob Peterson
The freeze glock was used in several places whenever a gfs2 file system was frozen, thawed, mounted, unmounted, remounted, or withdrawn. It was used to prevent those things from clashing with one another. Function freeze_go_xmote_bh only checked if the journal was clean in cases where the journal

[Cluster-devel] [GFS2 PATCH 3/3] gfs2: Eliminate go_xmote_bh in favor of go_lock

2021-08-24 Thread Bob Peterson
Before this patch, the freeze glock was the only glock to use the go_xmote_bh glock op (glop). The go_xmote_bh glop is done when a glock is locked. But so is go_lock. This patch eliminates the glop altogether in favor of just using go_lock for the freeze glock. This is for better consistency,

[Cluster-devel] [GFS2 PATCH 1/3] gfs2: switch go_xmote_bh glop to pass gh not gl

2021-08-24 Thread Bob Peterson
Before this patch, the go_xmote_bh function was passed gl, the glock pointer. This patch switches it to gh, the holder, which points to the gl. This facilitates improvements for the next patch. Signed-off-by: Bob Peterson --- fs/gfs2/glock.c | 4 ++-- fs/gfs2/glops.c | 5 +++--

Re: [Cluster-devel] FS/DLM module triggered kernel BUG

2021-08-24 Thread Gang He
On 2021/8/23 21:49, Alexander Aring wrote: Hi Gang He, On Mon, Aug 23, 2021 at 1:43 AM Gang He wrote: Hello Guys, I used kernel 5.13.8, I sometimes encountered the dlm module triggered kernel BUG. What do you exactly do? I would like to test it on a recent upstream version, or you can

Re: [Cluster-devel] [PATCH v6 10/19] gfs2: Introduce flag for glock holder auto-demotion

2021-08-24 Thread Steven Whitehouse
Hi, On Mon, 2021-08-23 at 17:18 +0200, Andreas Gruenbacher wrote: > On Mon, Aug 23, 2021 at 10:14 AM Steven Whitehouse < > swhit...@redhat.com> wrote: > > On Fri, 2021-08-20 at 17:22 +0200, Andreas Gruenbacher wrote: > > > On Fri, Aug 20, 2021 at 3:11 PM Bob Peterson > > > > > > wrote: > >