Re: [Cluster-devel] [GIT PULL] gfs2 fixes

2022-02-11 Thread Andreas Gruenbacher
On Fri, Feb 11, 2022 at 8:48 PM Linus Torvalds wrote: > On Fri, Feb 11, 2022 at 9:05 AM Andreas Gruenbacher > wrote: > > > > * Revert debug commit that causes unexpected data corruption. > > Well, apparently not just unexpected, but unexplained too. > > That's a bit worrisome. It sounds like the

Re: [Cluster-devel] [GIT PULL] gfs2 fixes

2022-02-11 Thread pr-tracker-bot
The pull request you sent on Fri, 11 Feb 2022 18:05:22 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git > tags/gfs2-v5.16-rc3-fixes2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/8ce964b520ad0ad626cb1ee93a444aedceed5425 Thank you! -- Deet

Re: [Cluster-devel] [GIT PULL] gfs2 fixes

2022-02-11 Thread Linus Torvalds
On Fri, Feb 11, 2022 at 9:05 AM Andreas Gruenbacher wrote: > > * Revert debug commit that causes unexpected data corruption. Well, apparently not just unexpected, but unexplained too. That's a bit worrisome. It sounds like the corruption cause is still there, just hidden by the lack of __cond_re

[Cluster-devel] [GIT PULL] gfs2 fixes

2022-02-11 Thread Andreas Gruenbacher
Hi Linus, please consider pulling the following two gfs2 fixes for 5.17-rc4. Thanks, Andreas The following changes since commit 74382e277ae97b4bcfac6f8b61df7a500d392500: gfs2: dump inode object for iopen glocks (2022-01-11 16:52:44 +0100) are available in the Git repository at: git://git.

[Cluster-devel] [PATCH] gfs2: Move iomap_get before taking sd_quota_mutex

2022-02-11 Thread Bob Peterson
Before this patch quota function bh_get called gfs2_iomap_get after it had locked the sd_quota_mutex. That's a problem because that holds the i_rw_mutex, and that lock order is different from other code that locks i_rw_mutex first, then the sd_quota_mutex: punch_hole sweep_bh_for_rgrps do

[Cluster-devel] [PATCH] gfs2: Convert function bh_get to use iomap

2022-02-11 Thread Bob Peterson
Before this patch, function bh_get used block_map to figure out the block it needed to read in from the quota_change file. This patch changes it to use iomap directly to make it more efficient. Signed-off-by: Bob Peterson --- fs/gfs2/quota.c | 15 +++ 1 file changed, 11 insertions(+)

[Cluster-devel] [PATCH] gfs2: use i_lock spin_lock for inode qadata

2022-02-11 Thread Bob Peterson
Before this patch, functions gfs2_qa_get and _put used the i_rw_mutex to prevent simultaneous access to its i_qadata. But i_rw_mutex is now used for many other things, including iomap_begin and end, which causes a conflict according to lockdep. We cannot just remove the lock since simultaneous open

Re: [Cluster-devel] [PATCH 1/1] Revert "iomap: fall back to buffered writes for invalidation failures"

2022-02-11 Thread Matthew Wilcox
On Thu, Feb 10, 2022 at 10:15:52AM +, Lee Jones wrote: > On Wed, 09 Feb 2022, Darrick J. Wong wrote: > > > On Wed, Feb 09, 2022 at 08:52:43AM +, Lee Jones wrote: > > > This reverts commit 60263d5889e6dc5987dc51b801be4955ff2e4aa7. > > > > > > Reverting since this commit opens a potential a