Re: [Cluster-devel] [RFC v6 04/10] iomap: Add iomap_get_folio helper

2023-01-11 Thread Dave Chinner
On Wed, Jan 11, 2023 at 07:36:26PM +, Matthew Wilcox wrote: > On Tue, Jan 10, 2023 at 07:24:27AM -0800, Christoph Hellwig wrote: > > On Tue, Jan 10, 2023 at 01:34:16PM +, Matthew Wilcox wrote: > > > > Exactly. And as I already pointed out in reply to Dave's original > > > > patch what we r

Re: [Cluster-devel] [RFC v6 04/10] iomap: Add iomap_get_folio helper

2023-01-11 Thread Matthew Wilcox
On Tue, Jan 10, 2023 at 07:24:27AM -0800, Christoph Hellwig wrote: > On Tue, Jan 10, 2023 at 01:34:16PM +, Matthew Wilcox wrote: > > > Exactly. And as I already pointed out in reply to Dave's original > > > patch what we really should be doing is returning an ERR_PTR from > > > __filemap_get_f

Re: [Cluster-devel] [PATCH v2 16/16] kobject: kset_uevent_ops: make uevent() callback take a const *

2023-01-11 Thread Rafael J. Wysocki
On Wed, Jan 11, 2023 at 12:30 PM Greg Kroah-Hartman wrote: > > The uevent() callback in struct kset_uevent_ops does not modify the > kobject passed into it, so make the pointer const to enforce this > restriction. When doing so, fix up all existing uevent() callbacks to > have the correct signatu

Re: [Cluster-devel] [PATCH v2] filelock: move file locking definitions to separate header file

2023-01-11 Thread Russell King (Oracle)
On Thu, Jan 05, 2023 at 04:19:29PM -0500, Jeff Layton wrote: > The file locking definitions have lived in fs.h since the dawn of time, > but they are only used by a small subset of the source files that > include it. > > Move the file locking definitions to a new header file, and add the > appropr

[Cluster-devel] [PATCH v2 16/16] kobject: kset_uevent_ops: make uevent() callback take a const *

2023-01-11 Thread Greg Kroah-Hartman
The uevent() callback in struct kset_uevent_ops does not modify the kobject passed into it, so make the pointer const to enforce this restriction. When doing so, fix up all existing uevent() callbacks to have the correct signature to preserve the build. Cc: "Rafael J. Wysocki" Cc: Christine Caul

Re: [Cluster-devel] [PATCH v2] filelock: move file locking definitions to separate header file

2023-01-11 Thread Jeff Layton
On Wed, 2023-01-11 at 02:12 +, Al Viro wrote: > On Thu, Jan 05, 2023 at 04:19:29PM -0500, Jeff Layton wrote: > > The file locking definitions have lived in fs.h since the dawn of time, > > but they are only used by a small subset of the source files that > > include it. > > > > Move the file l