[Cluster-devel] [PATCH] gfs2: Improve gfs2_make_fs_rw error handling

2023-01-31 Thread Andreas Gruenbacher
In gfs2_make_fs_rw(), make sure to call gfs2_consist() to report an inconsistency and mark the filesystem as withdrawn when gfs2_find_jhead() fails. At the end of gfs2_make_fs_rw(), when we discover that the filesystem has been withdrawn, make sure we report an error. This also replaces the

Re: [Cluster-devel] [RFC v6 05/10] iomap/gfs2: Get page in page_prepare handler

2023-01-31 Thread Andreas Gruenbacher
On Tue, Jan 31, 2023 at 8:37 PM Matthew Wilcox wrote: > On Sun, Jan 08, 2023 at 08:40:29PM +0100, Andreas Gruenbacher wrote: > > +static struct folio * > > +gfs2_iomap_page_prepare(struct iomap_iter *iter, loff_t pos, unsigned len) > > { > > + struct inode *inode = iter->inode; > >

Re: [Cluster-devel] [RFC v6 05/10] iomap/gfs2: Get page in page_prepare handler

2023-01-31 Thread Matthew Wilcox
On Sun, Jan 08, 2023 at 08:40:29PM +0100, Andreas Gruenbacher wrote: > +static struct folio * > +gfs2_iomap_page_prepare(struct iomap_iter *iter, loff_t pos, unsigned len) > { > + struct inode *inode = iter->inode; > unsigned int blockmask = i_blocksize(inode) - 1; > struct

[Cluster-devel] [PATCH AUTOSEL 6.1 10/20] Revert "gfs2: stop using generic_writepages in gfs2_ail1_start_one"

2023-01-31 Thread Sasha Levin
From: Andreas Gruenbacher [ Upstream commit 95ecbd0f162fc06ef4c4045a66f653f47b62a2d3 ] Commit b2b0a5e97855 switched from generic_writepages() to filemap_fdatawrite_wbc() in gfs2_ail1_start_one() on the path to replacing ->writepage() with ->writepages() and eventually eliminating the former.

Re: [Cluster-devel] [syzbot] INFO: task hung in freeze_super (3)

2023-01-31 Thread Andreas Gruenbacher
Hello, On Wed, Jan 4, 2023 at 3:37 PM Tetsuo Handa wrote: > syzbot is reporting hung task at freeze_super() after emitting > "gfs2: fsid=loop0.0: can't make FS RW: -5" message due to gfs2_find_jhead() > from gfs2_make_fs_rw() from gfs2_fill_super() failing with -EIO. > > When hung task message

[Cluster-devel] [PATCH dlm-tool] dlm_controld: add gcc format printf attribute to log_level

2023-01-31 Thread Alexander Aring
This patch will add __attribute__ (( format( printf, 3, 4 ) ) to log_level() functionality which has a format string as parameter. With this change we enable compiler warnings if format string and applied parameters do not match. We had some couple of warnings which this patch fixes as well. ---