Re: [Cluster-devel] [PATCH 7/9] gfs2: update ctime when quota is updated

2023-06-09 Thread Andreas Gruenbacher
Jeff, On Fri, Jun 9, 2023 at 2:50 PM Jeff Layton wrote: > Signed-off-by: Jeff Layton > --- > fs/gfs2/quota.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c > index 1ed17226d9ed..6d283e071b90 100644 > --- a/fs/gfs2/quota.c > +++

Re: [Cluster-devel] [PATCH 0/9] fs: add some missing ctime updates

2023-06-09 Thread Jeff Layton
On Fri, 2023-06-09 at 15:10 +0200, Greg Kroah-Hartman wrote: > On Fri, Jun 09, 2023 at 08:50:14AM -0400, Jeff Layton wrote: > > While working on a patch series to change how we handle the ctime, I > > found a number of places that update the mtime without a corresponding > > ctime update. POSIX

Re: [Cluster-devel] [PATCH 0/9] fs: add some missing ctime updates

2023-06-09 Thread Greg Kroah-Hartman
On Fri, Jun 09, 2023 at 08:50:14AM -0400, Jeff Layton wrote: > While working on a patch series to change how we handle the ctime, I > found a number of places that update the mtime without a corresponding > ctime update. POSIX requires that when the mtime is updated that the > ctime also be

Re: [Cluster-devel] [PATCH 2/9] usb: update the ctime as well when updating mtime after an ioctl

2023-06-09 Thread Greg Kroah-Hartman
On Fri, Jun 09, 2023 at 08:50:16AM -0400, Jeff Layton wrote: > Signed-off-by: Jeff Layton Sorry, but I can't take commits without any changelog text at all (nor would you want me to...) thanks, greg k-h

[Cluster-devel] [PATCH 2/9] usb: update the ctime as well when updating mtime after an ioctl

2023-06-09 Thread Jeff Layton
Signed-off-by: Jeff Layton --- drivers/usb/core/devio.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index fcf68818e999..1268d313a8df 100644 --- a/drivers/usb/core/devio.c +++ b/drivers/usb/core/devio.c

[Cluster-devel] [PATCH 6/9] exfat: ensure that ctime is updated whenever the mtime is

2023-06-09 Thread Jeff Layton
Signed-off-by: Jeff Layton --- fs/exfat/namei.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/exfat/namei.c b/fs/exfat/namei.c index e0ff9d156f6f..d9b46fa36bff 100644 --- a/fs/exfat/namei.c +++ b/fs/exfat/namei.c @@ -817,7 +817,7 @@ static int exfat_unlink(struct

[Cluster-devel] [PATCH 8/9] apparmor: update ctime whenever the mtime changes on an inode

2023-06-09 Thread Jeff Layton
Signed-off-by: Jeff Layton --- security/apparmor/apparmorfs.c| 7 +-- security/apparmor/policy_unpack.c | 11 +++ 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/security/apparmor/apparmorfs.c b/security/apparmor/apparmorfs.c index db7a51acf9db..c06053718836

[Cluster-devel] [PATCH 9/9] cifs: update the ctime on a partial page write

2023-06-09 Thread Jeff Layton
Signed-off-by: Jeff Layton --- fs/smb/client/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/smb/client/file.c b/fs/smb/client/file.c index df88b8c04d03..a00038a326cf 100644 --- a/fs/smb/client/file.c +++ b/fs/smb/client/file.c @@ -2596,7 +2596,7 @@ static int

[Cluster-devel] [PATCH 5/9] efivarfs: update ctime when mtime changes on a write

2023-06-09 Thread Jeff Layton
Signed-off-by: Jeff Layton --- fs/efivarfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/efivarfs/file.c b/fs/efivarfs/file.c index d57ee15874f9..375576111dc3 100644 --- a/fs/efivarfs/file.c +++ b/fs/efivarfs/file.c @@ -51,7 +51,7 @@ static ssize_t

[Cluster-devel] [PATCH 4/9] bfs: update ctime in addition to mtime when adding entries

2023-06-09 Thread Jeff Layton
Signed-off-by: Jeff Layton --- fs/bfs/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/bfs/dir.c b/fs/bfs/dir.c index 040d5140e426..d2e8a2a56b05 100644 --- a/fs/bfs/dir.c +++ b/fs/bfs/dir.c @@ -294,7 +294,7 @@ static int bfs_add_entry(struct inode *dir, const struct

[Cluster-devel] [PATCH 1/9] ibmvmc: update ctime in conjunction with mtime on write

2023-06-09 Thread Jeff Layton
When updating the mtime for a write, you must always update the ctime as well. Signed-off-by: Jeff Layton --- drivers/misc/ibmvmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/ibmvmc.c b/drivers/misc/ibmvmc.c index cbaf6d35e854..d7c7f0305257 100644 ---

[Cluster-devel] [PATCH 7/9] gfs2: update ctime when quota is updated

2023-06-09 Thread Jeff Layton
Signed-off-by: Jeff Layton --- fs/gfs2/quota.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c index 1ed17226d9ed..6d283e071b90 100644 --- a/fs/gfs2/quota.c +++ b/fs/gfs2/quota.c @@ -869,7 +869,7 @@ static int gfs2_adjust_quota(struct

[Cluster-devel] [PATCH 3/9] autofs: set ctime as well when mtime changes on a dir

2023-06-09 Thread Jeff Layton
Signed-off-by: Jeff Layton --- fs/autofs/root.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/autofs/root.c b/fs/autofs/root.c index 6baf90b08e0e..93046c9dc461 100644 --- a/fs/autofs/root.c +++ b/fs/autofs/root.c @@ -600,7 +600,7 @@ static int

[Cluster-devel] [PATCH 0/9] fs: add some missing ctime updates

2023-06-09 Thread Jeff Layton
While working on a patch series to change how we handle the ctime, I found a number of places that update the mtime without a corresponding ctime update. POSIX requires that when the mtime is updated that the ctime also be updated. Note that these are largely untested other than for compilation,