Re: [Cluster-devel] [PATCH] gfs2: Replace deprecated kmap_atomic() by kmap_local_page()

2023-06-27 Thread Deepak R Varma
On Tue, Jun 27, 2023 at 01:11:46PM +0200, Fabio M. De Francesco wrote: > On domenica 25 giugno 2023 21:23:21 CEST Deepak R Varma wrote: > > kmap_atomic() is deprecated in favor of kmap_local_{folio,page}(). > > > > } > > - p = kmap_atomic(page); > > + p =

Re: [Cluster-devel] [PATCH v2] gfs2: Replace deprecated kmap_atomic() by kmap_local_page()

2023-06-27 Thread Deepak R Varma
On Tue, Jun 27, 2023 at 03:45:20PM +0200, Andreas Gruenbacher wrote: > On Mon, Jun 26, 2023 at 8:51 AM Deepak R Varma wrote: > > kmap_atomic() is deprecated in favor of kmap_local_{folio,page}(). > > I'll apply this, convert the remaining instances of kmap_atomic(), and > switch to

[Cluster-devel] [PATCH 2/2] gfs2: Use memcpy_{from, to}_page where appropriate

2023-06-27 Thread Andreas Gruenbacher
Replace kmap_local_page() + memcpy() + kunmap_local() sequences with memcpy_{from,to}_page() where we are not doing anything else with the mapped page. Signed-off-by: Andreas Gruenbacher --- fs/gfs2/aops.c | 5 + fs/gfs2/lops.c | 12 +--- fs/gfs2/quota.c | 5 + 3 files

[Cluster-devel] [PATCH 1/2] gfs2: Convert remaining kmap_atomic calls to kmap_local_page

2023-06-27 Thread Andreas Gruenbacher
Replace the remaining instances of kmap_atomic() ... kunmap_atomic() with kmap_local_page() ... kunmap_local(). Signed-off-by: Andreas Gruenbacher --- fs/gfs2/lops.c | 13 +++-- fs/gfs2/quota.c | 4 ++-- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/fs/gfs2/lops.c

Re: [Cluster-devel] [PATCH v2] gfs2: Replace deprecated kmap_atomic() by kmap_local_page()

2023-06-27 Thread Andreas Gruenbacher
On Mon, Jun 26, 2023 at 8:51 AM Deepak R Varma wrote: > kmap_atomic() is deprecated in favor of kmap_local_{folio,page}(). I'll apply this, convert the remaining instances of kmap_atomic(), and switch to memcpy_{from,to}_page() where appropriate. Thanks, Andreas > Therefore, replace

[Cluster-devel] [PATCH] gfs: Get rid of unnucessary locking in inode_go_dump

2023-06-27 Thread Andreas Gruenbacher
Commit 27a2660f1ef9 ("gfs2: Dump nrpages for inodes and their glocks") added some locking around reading inode->i_data.nrpages. That locking doesn't do anything really, so get rid of it. With that, the glock argument to ->go_dump() can be made const again as well. Signed-off-by: Andreas

Re: [Cluster-devel] [PATCH v2] gfs2: Replace deprecated kmap_atomic() by kmap_local_page()

2023-06-27 Thread Fabio M. De Francesco
On lunedì 26 giugno 2023 08:51:09 CEST Deepak R Varma wrote: > kmap_atomic() is deprecated in favor of kmap_local_{folio,page}(). > > Therefore, replace kmap_atomic() with kmap_local_page() in > gfs2_internal_read() and stuffed_readpage(). > > kmap_atomic() disables page-faults and preemption

Re: [Cluster-devel] [PATCH] gfs2: Replace deprecated kmap_atomic() by kmap_local_page()

2023-06-27 Thread Fabio M. De Francesco
On domenica 25 giugno 2023 21:23:21 CEST Deepak R Varma wrote: > kmap_atomic() is deprecated in favor of kmap_local_{folio,page}(). > > Therefore, replace kmap_atomic() with kmap_local_folio() in > gfs2_internal_read() and stuffed_readpage(). > > kmap_atomic() disables page-faults and preemption