Re: [Cluster-devel] allow building a kernel without buffer_heads

2023-07-20 Thread Bob Peterson
On 7/20/23 9:04 AM, Christoph Hellwig wrote: Hi all, This series allows to build a kernel without buffer_heads, which I think is useful to show where the dependencies are, and maybe also for some very much limited environments, where people just needs xfs and/or btrfs and some of the read-only

[Cluster-devel] [RFC v6.5-rc2 2/3] fs: lockd: fix race in async lock request handling

2023-07-20 Thread Alexander Aring
This patch fixes a race in async lock request handling between adding the relevant struct nlm_block to nlm_blocked list after the request was sent by vfs_lock_file() and nlmsvc_grant_deferred() does a lookup of the nlm_block in the nlm_blocked list. It could be that the async request is completed

[Cluster-devel] [RFC v6.5-rc2 3/3] fs: lockd: introduce safe async lock op

2023-07-20 Thread Alexander Aring
This patch reverts mostly commit 40595cdc93ed ("nfs: block notification on fs with its own ->lock") and introduces an EXPORT_OP_SAFE_ASYNC_LOCK export flag to signal that the "own ->lock" implementation supports async lock requests. The only main user is DLM that is used by GFS2 and OCFS2

[Cluster-devel] [RFC v6.5-rc2 1/3] fs: lockd: nlm_blocked list race fixes

2023-07-20 Thread Alexander Aring
This patch fixes races when lockd accessing the global nlm_blocked list. It was mostly safe to access the list because everything was accessed from the lockd kernel thread context but there exists cases like nlmsvc_grant_deferred() that could manipulate the nlm_blocked list and it can be called

[Cluster-devel] [PATCHv4 v6.5-rc2 3/3] fs: dlm: fix F_CANCELLK to cancel pending request

2023-07-20 Thread Alexander Aring
This patch fixes the current handling of F_CANCELLK by not just doing a unlock as we need to try to cancel a lock at first. A unlock makes sense on a non-blocking lock request but if it's a blocking lock request we need to cancel the request until it's not granted yet. This patch is fixing this

[Cluster-devel] [PATCHv4 v6.5-rc2 2/3] fs: dlm: allow to F_SETLKW getting interrupted

2023-07-20 Thread Alexander Aring
This patch implements dlm plock F_SETLKW interruption feature. If a blocking posix lock request got interrupted in user space by a signal a cancellation request for a non granted lock request to the user space lock manager will be send. The user lock manager answers either with zero or a negative

[Cluster-devel] [PATCHv4 v6.5-rc2 1/3] fs: dlm: remove twice newline

2023-07-20 Thread Alexander Aring
This patch removes a newline which log_print() already adds, also removes wrapped string that causes a checkpatch warning. --- fs/dlm/plock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/dlm/plock.c b/fs/dlm/plock.c index 70a4752ed913..a34f605d8505 100644 ---

Re: [Cluster-devel] [PATCH 16/17] block: use iomap for writes to block devices

2023-07-20 Thread Hannes Reinecke
On 7/20/23 14:06, Christoph Hellwig wrote: On Fri, May 19, 2023 at 04:22:01PM +0200, Hannes Reinecke wrote: I'm hitting this during booting: [5.016324] [5.030256] iomap_iter+0x11a/0x350 [5.030264] iomap_readahead+0x1eb/0x2c0 [5.030272] read_pages+0x5d/0x220 [5.030279]

[Cluster-devel] [PATCHv4 v6.5-rc2 0/3] fs: dlm: lock cancellation feature

2023-07-20 Thread Alexander Aring
Hi, this patch series implements lock cancellation feature. Either if a POSIX F_SETLKW got interrupted by a signal (most common use case) or lockd sends a F_CANCELLK request. As I note: the current nfs handling seems to be broken. This patch assumes that the current behaviour works. Future

Re: [Cluster-devel] [PATCH 16/17] block: use iomap for writes to block devices

2023-07-20 Thread Christoph Hellwig
On Wed, May 24, 2023 at 02:33:13PM +0100, Matthew Wilcox wrote: > As you can see, do_page_cache_ra() does limit readahead to i_size. > Is ractl->mapping->host the correct way to find the inode? I always > get confused. As far as I can tell it is the right inode, the indirection through

Re: [Cluster-devel] [PATCH 16/17] block: use iomap for writes to block devices

2023-07-20 Thread Christoph Hellwig
On Fri, May 19, 2023 at 04:22:01PM +0200, Hannes Reinecke wrote: > I'm hitting this during booting: > [5.016324] > [5.030256] iomap_iter+0x11a/0x350 > [5.030264] iomap_readahead+0x1eb/0x2c0 > [5.030272] read_pages+0x5d/0x220 > [5.030279]