Re: [Cluster-devel] [PATCH v6 2/7] fs: add infrastructure for multigrain timestamps

2023-08-02 Thread Jeff Layton
On Wed, 2023-08-02 at 21:35 +0200, Jan Kara wrote: > On Tue 25-07-23 10:58:15, Jeff Layton wrote: > > The VFS always uses coarse-grained timestamps when updating the ctime > > and mtime after a change. This has the benefit of allowing filesystems > > to optimize away a lot metadata updates, down

Re: [Cluster-devel] [PATCH v6 6/7] ext4: switch to multigrain timestamps

2023-08-02 Thread Jan Kara
On Tue 25-07-23 10:58:19, Jeff Layton wrote: > Enable multigrain timestamps, which should ensure that there is an > apparent change to the timestamp whenever it has been written after > being actively observed via getattr. > > For ext4, we only need to enable the FS_MGTIME flag. > >

Re: [Cluster-devel] [PATCH v6 4/7] tmpfs: add support for multigrain timestamps

2023-08-02 Thread Jan Kara
On Tue 25-07-23 10:58:17, Jeff Layton wrote: > Enable multigrain timestamps, which should ensure that there is an > apparent change to the timestamp whenever it has been written after > being actively observed via getattr. > > tmpfs only requires the FS_MGTIME flag. > > Signed-off-by: Jeff

Re: [Cluster-devel] [PATCH v6 2/7] fs: add infrastructure for multigrain timestamps

2023-08-02 Thread Jan Kara
On Tue 25-07-23 10:58:15, Jeff Layton wrote: > The VFS always uses coarse-grained timestamps when updating the ctime > and mtime after a change. This has the benefit of allowing filesystems > to optimize away a lot metadata updates, down to around 1 per jiffy, > even when a file is under heavy

Re: [Cluster-devel] [PATCH v6 5/7] xfs: switch to multigrain timestamps

2023-08-02 Thread Jeff Layton
On Wed, 2023-08-02 at 10:48 -0700, Darrick J. Wong wrote: > On Tue, Jul 25, 2023 at 10:58:18AM -0400, Jeff Layton wrote: > > Enable multigrain timestamps, which should ensure that there is an > > apparent change to the timestamp whenever it has been written after > > being actively observed via

Re: [Cluster-devel] [PATCH v6 5/7] xfs: switch to multigrain timestamps

2023-08-02 Thread Darrick J. Wong
On Tue, Jul 25, 2023 at 10:58:18AM -0400, Jeff Layton wrote: > Enable multigrain timestamps, which should ensure that there is an > apparent change to the timestamp whenever it has been written after > being actively observed via getattr. > > Also, anytime the mtime changes, the ctime must also

Re: [Cluster-devel] [PATCH v6 1/7] fs: pass the request_mask to generic_fillattr

2023-08-02 Thread Jan Kara
On Tue 25-07-23 10:58:14, Jeff Layton wrote: > generic_fillattr just fills in the entire stat struct indiscriminately > today, copying data from the inode. There is at least one attribute > (STATX_CHANGE_COOKIE) that can have side effects when it is reported, > and we're looking at adding more

Re: [Cluster-devel] [bug report] gfs2: Use mapping->gfp_mask for metadata inodes

2023-08-02 Thread Andreas Gruenbacher
On Wed, Aug 2, 2023 at 9:35 AM Dan Carpenter wrote: > Hello Andreas Gruenbacher, > > The patch 8f18190e3173: "gfs2: Use mapping->gfp_mask for metadata > inodes" from Jul 26, 2023 (linux-next), leads to the following Smatch > static checker warning: > > fs/gfs2/inode.c:286

[Cluster-devel] [syzbot] Monthly gfs2 report (Aug 2023)

2023-08-02 Thread syzbot
Hello gfs2 maintainers/developers, This is a 31-day syzbot report for the gfs2 subsystem. All related reports/information can be found at: https://syzkaller.appspot.com/upstream/s/gfs2 During the period, 3 new issues were detected and 0 were fixed. In total, 18 issues are still open and 18 have

[Cluster-devel] [bug report] gfs2: Use mapping->gfp_mask for metadata inodes

2023-08-02 Thread Dan Carpenter
Hello Andreas Gruenbacher, The patch 8f18190e3173: "gfs2: Use mapping->gfp_mask for metadata inodes" from Jul 26, 2023 (linux-next), leads to the following Smatch static checker warning: fs/gfs2/inode.c:286 gfs2_lookup_simple() error: 'inode' dereferencing possible ERR_PTR()