On 29/07/14 23:25, Abhijith Das wrote:
- Original Message -
From: Jonathan Corbet cor...@lwn.net
To: Abhi Das a...@redhat.com
Cc: linux-ker...@vger.kernel.org, linux-fsde...@vger.kernel.org,
cluster-devel@redhat.com
Sent: Tuesday, July 29, 2014 1:58:08 PM
Subject: Re: [RFC PATCH 5/5]
Hi,
On 28/07/14 22:19, Andreas Dilger wrote:
On Jul 28, 2014, at 6:52 AM, Abhijith Das a...@redhat.com wrote:
OnJuly 26, 2014 12:27:19 AM Andreas Dilger adil...@dilger.ca wrote:
Is there a time when this doesn't get called to prefetch entries in
readdir() order? It isn't clear to me what
Hi,
Linus has pulled the -fixes tree, so I've rebased the -nmw tree which
now has only a single patch in it,
Steve.
, and was therefore safer.
Signed-off-by: Bob Peterson rpete...@redhat.com
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
index 4fc3a30..491e8e0 100644
--- a/fs/gfs2/file.c
+++ b/fs/gfs2/file.c
@@ -991,7 +991,7 @@ static int do_flock(struct file *file
is blocked.
This problem is especially apparent when dealing with nested flocks.
Signed-off-by: Bob Peterson rpete...@redhat.com
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index c355f73..278fae5 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2
Hi,
On 10/07/14 17:53, Bob Peterson wrote:
Hi,
This patch reports how much time was taken in each pass.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson rpete...@redhat.com
---
gfs2/fsck/main.c | 19 ++-
1 file changed, 18 insertions(+), 1
Hi,
On 10/07/14 17:54, Bob Peterson wrote:
Hi,
This patch introduces file read-ahead to pass1.
Why not the other passes too? Is that just because they are not checking
all the indirect data?
Steve.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson
Hi,
Now in the -nmw tree. Thanks,
Steve.
On 29/06/14 11:21, Geert Uytterhoeven wrote:
Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org
Cc: Steven Whitehouse swhit...@redhat.com
Cc: cluster-devel@redhat.com
---
fs/gfs2/glops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
Hi,
Now in the -nmw git tree. Thanks,
Steve.
On 25/06/14 19:40, Fabian Frederick wrote:
kcalloc manages count*sizeof overflow.
Cc: Steven Whitehouse swhit...@redhat.com
Cc: cluster-devel@redhat.com
Signed-off-by: Fabian Frederick f...@skynet.be
---
fs/gfs2/lock_dlm.c | 4 ++--
1 file
Hi,
Both patches are now in the -nmw tree. Thanks,
Steve.
On Thu, 2014-06-26 at 10:46 -0400, Bob Peterson wrote:
Hi,
This patch allows flock glocks to use a non-blocking dequeue rather
than dq_wait. It also reverts the previous patch I had posted regarding
dq_wait. The reverted patch
iteration.
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index c355f73..e607b02 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
@@ -1404,12 +1404,16 @@ __acquires(lru_lock)
gl = list_entry(list-next, struct gfs2_glock, gl_lru
Hi,
Now in the -nmw tree. Thanks,
Steve.
On 20/06/14 14:36, Bob Peterson wrote:
Hi,
Function gfs2_glock_dq_wait is supposed to dequeue a glock and then
wait for the lock to be demoted. The problem is, if this is a shared
lock, its demote will depend on the other holders, which means you
Hi,
Yes, its not ideal, but it is a worthwhile step forward I think.
ACK,
Steve.
On 06/06/14 20:16, Benjamin Marzinski wrote:
GFS wasn't ever updating mtime during mmaps to a file. This patch makes
gfs_write_inode write the vfs inode attributes out to disk if it can, so
that they get updated
Hi,
On 05/06/14 02:28, Andrew Price wrote:
block_is_in_per_node() only checks the first leaf block when the
per_node directory has been split (when the block size is small and/or
the number of journals is large). This caused savemeta to treat the
files in per_node as user data and so didn't
Hi,
Please consider pulling the following changes,
Steve.
-
The following changes since commit 6ca2a88ad820af56535ed1e6936e0490cb6ec6dc:
Merge branch 'x86-urgent-for-linus' of
Hi,
This must be about the smallest merge window patch set ever for GFS2.
It is probably also the first one without a single patch from me. That
is down to a combination of factors, and I have some things in the works
that are not quite ready yet, that I hope to put in next time around.
From: Fabian Frederick f...@skynet.be
Related function is not gfs2_set_flags but do_gfs2_set_flags
Cc: Andrew Morton a...@linux-foundation.org
Signed-off-by: Fabian Frederick f...@skynet.be
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
index
From: Fabian Frederick f...@skynet.be
Sparse warning: fs/gfs2/lops.c:78:29:
warning: Using plain integer as NULL pointer
Cc: Andrew Morton a...@linux-foundation.org
Signed-off-by: Fabian Frederick f...@skynet.be
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/lops.c b
-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c
index c4e..6193896 100644
--- a/fs/gfs2/quota.c
+++ b/fs/gfs2/quota.c
@@ -778,6 +778,7 @@ get_a_page:
i_size_write(inode, size);
inode-i_mtime = inode-i_atime = CURRENT_TIME
From: Fabian Frederick f...@skynet.be
Fix 2 typos and move one definition which was between function
comments and function definition (yet another kernel-doc warning)
Cc: Andrew Morton a...@linux-foundation.org
Signed-off-by: Fabian Frederick f...@skynet.be
Signed-off-by: Steven Whitehouse swhit
...@redhat.com
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
index ce62dca..5a49b03 100644
--- a/fs/gfs2/aops.c
+++ b/fs/gfs2/aops.c
@@ -431,7 +431,7 @@ static int gfs2_jdata_writepages(struct address_space
*mapping,
ret = gfs2_write_cache_jdata
Hi,
Now in the -nmw tree. Thanks,
Steve.
On 02/06/14 14:40, Bob Peterson wrote:
Hi,
This is my fourth attempt at a recovery patch that prevents recovery
before the journal is set by GFS2.
Patch description:
This patch uses a completion to prevent dlm's recovery process from
referencing and
Hi,
Looks good to me. Thanks for fixing this,
Steve.
On 30/05/14 06:19, Benjamin Marzinski wrote:
GFS wasn't ever updating mtime during mmaps to a file. This patch makes
gfs_write_inode write the vfs inode attributes out to disk, so that they
get updated when the mmap data is written back to
Hi,
On 22/05/14 14:17, Bob Peterson wrote:
Hi,
This is my third attempt at a recovery patch that prevents recovery
before the journal is set by GFS2. Steve Whitehouse pointed out that
there were error paths in the code that could leave recovery permanently
hung, waiting for the completion. It
Hi,
On 19/05/14 12:54, Andrew Price wrote:
Previously 'gfs2_edit savemeta' just saved blocks into the file and any
characterisation of the contents had to be calculated by reading the
gfs2 structures out of it. Add a metadata header to savemeta output
files which initially holds the original fs
Hi,
On 19/05/14 13:15, Andrew Price wrote:
On 19/05/14 13:03, Steven Whitehouse wrote:
Hi,
On 19/05/14 12:54, Andrew Price wrote:
Previously 'gfs2_edit savemeta' just saved blocks into the file and any
characterisation of the contents had to be calculated by reading the
gfs2 structures out
Hi,
On 02/05/14 15:05, Bob Peterson wrote:
Hi,
This patch uses a completion to prevent dlm's recovery process from
referencing and trying to recover a journal before a journal has been
opened.
Regards,
Bob Peterson
Red Hat File Systems
There is one possible issue that I can see, which is the
Hi,
On 07/05/14 15:33, Andrew Price wrote:
In order to piece together the order in which fsck.gfs2 runs and
gfs2_edit savemeta were done it's useful to keep a log of the command
line options used and the fsck.gfs2 start and end times. Log these to
syslog.
Signed-off-by: Andrew Price
Hi,
Other patches in the series all look good to me,
Steve.
On 07/05/14 15:33, Andrew Price wrote:
libgfs2 was exposing a logging API (log_info, etc.) but wasn't using it
itself. Remove the logging bits and move them into
gfs2/include/logging.h
Signed-off-by: Andrew Price anpr...@redhat.com
Hi,
On 29/04/14 22:41, Josh Boyer wrote:
Hi All,
As part of the F21 Modular Kernel Packaging for Cloud Feature[1],
I've committed and pushed the kernel packaging split up into
kernel-core and kernel-drivers subpackages. For those of you running
rawhide, this really shouldn't be a major impact
improvement.
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c
index 9dcb977..1e1bda0 100644
--- a/fs/gfs2/log.c
+++ b/fs/gfs2/log.c
@@ -18,6 +18,7 @@
#include linux/kthread.h
#include linux/freezer.h
#include linux/bio.h
+#include linux/blkdev.h
From: Abhi Das a...@redhat.com
ENOSPC was being returned in slot_get inspite of successful
execution of the function. This patch fixes this return
code.
Signed-off-by: Abhi Das a...@redhat.com
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c
A couple of int fields were being used as boolean values
so we can make them bitfields of one bit, and put them in
what might otherwise be a hole in the structure with 64
bit alignment.
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h
index
.
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index 5c52418..ec455b9 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -376,12 +376,11 @@ static void munge_mode_uid_gid(const struct gfs2_inode
*dip,
inode-i_gid
From: Abhi Das a...@redhat.com
gfs2_lookupi() can return NULL if the path to the root is broken by
another rename/rmdir. In this case gfs2_ok_to_move() must check for
this NULL pointer and return error.
Resolves: rhbz#1060246
Signed-off-by: Abhi Das a...@redhat.com
Signed-off-by: Steven
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
index 39c7081..1a349f9 100644
--- a/fs/gfs2/dir.c
+++ b/fs/gfs2/dir.c
@@ -53,6 +53,8 @@
* but never before the maximum hash table size has been reached.
*/
+#define pr_fmt(fmt) KBUILD_MODNAME : fmt
Signed-off-by: Jie Liu jeff@oracle.com
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/acl.c b/fs/gfs2/acl.c
index ba94566..9c59ebe 100644
--- a/fs/gfs2/acl.c
+++ b/fs/gfs2/acl.c
@@ -86,7 +86,7 @@ int gfs2_set_acl(struct inode *inode, struct posix_acl *acl,
int type
From: Bob Peterson rpete...@redhat.com
Here is a revised patch based on Steve's feedback:
This patch eliminates function gfs2_set_mode which was only called in
one place, and always returned 0.
Signed-off-by: Bob Peterson rpete...@redhat.com
Signed-off-by: Steven Whitehouse swhit...@redhat.com
easier understand. Also, by reducing the
number of variables used to track the buffers being added
and removed from the journal, a number of error checks are
now no longer required.
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h
index 99aab64
From: Bob Peterson rpete...@redhat.com
This patch eliminates function gfs2_security_init in favor of just
calling security_inode_init_security directly.
Signed-off-by: Bob Peterson rpete...@redhat.com
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/inode.c b/fs/gfs2
From: Joe Perches j...@perches.com
vprintk use is not prefixed by a KERN_LEVEL,
so emit these messages at KERN_ERR level.
Using %pV can save some code and allow fs_err to
be used, so do it.
Signed-off-by: Joe Perches j...@perches.com
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff
From: Fabian Frederick f...@skynet.be
-All printk(KERN_foo converted to pr_foo().
-Messages updated to fit in 80 columns.
-fs_macros converted as well.
-fs_printk removed.
Signed-off-by: Fabian Frederick f...@skynet.be
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2
in multiple wrap points,
which itself leads to infinite loops in journal replay, both in the
kernel code and fsck.gfs2 code. This patch re-adds that call.
Signed-off-by: Bob Peterson rpete...@redhat.com
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c
index
From: Fabian Frederick f...@skynet.be
Use kzalloc and __vmalloc __GFP_ZERO for clean sd_quota_bitmap allocation.
Signed-off-by: Fabian Frederick f...@skynet.be
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c
index 8bec0e31..a5cccf6 100644
. This patch moves the necessary
variables so that each journal has its own separate area for tracking
its journal replay.
Signed-off-by: Bob Peterson rpete...@redhat.com
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h
index 456d8fa..ef26ed9 100644
is
also updated to show more detail about what went wrong.
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c
index fe0500c..c62d4b9 100644
--- a/fs/gfs2/bmap.c
+++ b/fs/gfs2/bmap.c
@@ -1328,6 +1328,121 @@ int gfs2_file_dealloc(struct gfs2_inode *ip
: rhbz#1059808
Signed-off-by: Abhi Das a...@redhat.com
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h
index ef26ed9..bdf70c1 100644
--- a/fs/gfs2/incore.h
+++ b/fs/gfs2/incore.h
@@ -371,6 +371,7 @@ enum {
GIF_ALLOC_FAILED= 2
a...@redhat.com
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c
index 005e468..2cf09b6 100644
--- a/fs/gfs2/meta_io.c
+++ b/fs/gfs2/meta_io.c
@@ -97,6 +97,11 @@ const struct address_space_operations gfs2_meta_aops = {
.releasepage
Hi,
On Mon, 2014-03-31 at 01:19 -0500, Abhi Das wrote:
ENOSPC was being returned in slot_get inspite of successful
execution of the function. This patch fixes this return
code.
Signed-off-by: Abhi Das a...@redhat.com
---
fs/gfs2/quota.c | 1 +
1 file changed, 1 insertion(+)
Now in the
Hi,
Yes, I think we might as well just merge it in, if there is only one
caller,
Steve.
On Wed, 2014-03-19 at 11:31 -0400, Bob Peterson wrote:
Hi,
This patch eliminates a return code from function gfs2_set_mode that
was always 0. We could also just eliminate the function altogether
Hi,
On Thu, 2014-03-13 at 17:23 +0100, Jan Kara wrote:
On Thu 13-03-14 10:20:56, Ted Tso wrote:
Previously, the no-op mount -o mount /dev/xxx operation when the
^^remount
file system is already mounted read-write causes an implied,
unconditional
Hi,
On Wed, 2014-03-12 at 03:41 -0500, Abhi Das wrote:
gfs2_lookupi() can return NULL if the path to the root is broken by
another rename/rmdir. In this case gfs2_ok_to_move() must check for
this NULL pointer and return error.
Resolves: rhbz#1060246
Signed-off-by: Abhi Das a...@redhat.com
,
Steve.
- Original Message -
From: Steven Whitehouse swhit...@redhat.com
To: Abhi Das a...@redhat.com
Cc: cluster-devel@redhat.com
Sent: Wednesday, March 12, 2014 5:03:20 AM
Subject: Re: [Cluster-devel] [GFS2 PATCH] GFS2: check NULL return value in
gfs2_ok_to_move
Hi
Hi,
On Wed, 2014-03-12 at 10:32 -0400, Bob Peterson wrote:
Hi,
This patch closes a small timing window whereby a request to hold the
transaction glock can get stuck. The problem is that after the DLM has
granted the lock, it can get into a state whereby it doesn't transition
the glock to a
Hi,
On Thu, 2014-03-06 at 17:19 -0500, Bob Peterson wrote:
Hi,
If multiple nodes fail and their recovery work runs simultaneously, they
would use the same unprotected variables in the superblock. For example,
they would stomp on each other's revoked blocks lists, which resulted
in file
From b50f227bddf110ae4ea2df1ebdf7e282ad481803 Mon Sep 17 00:00:00 2001
From: Steven Whitehouse swhit...@redhat.com
Date: Mon, 3 Mar 2014 13:35:57 +
Subject: GFS2: Clean up journal extent mapping
This patch fixes a long standing issue in mapping the journal
extents. Most journals will consist
Hi,
On Thu, 2014-03-06 at 08:46 -0500, Bob Peterson wrote:
- Original Message -
| +int gfs2_map_journal_extents(struct gfs2_sbd *sdp, struct gfs2_jdesc *jd)
| +{
| + u64 lblock = 0;
| + u64 lblock_stop;
| + struct gfs2_inode *ip = GFS2_I(jd-jd_inode);
| + struct buffer_head
Hi,
Now in the -nmw tree. Thanks,
Steve.
On Tue, 2014-03-04 at 11:28 +0800, Jeff Liu wrote:
From: Jie Liu jeff@oracle.com
Return -E2BIG rather than -EINVAL if hit the maximum size limits of
ACLs, as the former errno is consistent with VFS xattr syscalls.
This is pointed out by Dave
From b1ab1e44b4fa3df97a25cc9bcc3c99244ad6945b Mon Sep 17 00:00:00 2001
From: Steven Whitehouse swhit...@redhat.com
Date: Tue, 25 Feb 2014 11:52:20 +
Subject: GFS2: Remove extra if in gfs2_log_flush()
By reordering some of the assignments in gfs2_log_flush() it
is possible to remove one
From 928b2a81bde301e52f9dba2cae56e7b99ded07df Mon Sep 17 00:00:00 2001
From: Steven Whitehouse swhit...@redhat.com
Date: Fri, 21 Feb 2014 21:55:33 +
Subject: GFS2: Move log buffer accounting to transaction
Now we have a master transaction into which other transactions
are merged
Hi,
On Mon, 2014-02-17 at 14:47 +, Andrew Price wrote:
Kernel commit 01bcb0de introduces new gfs2_leaf fields. This patch adds
support for those fields to libgfs2, conditional upon them being
discovered in the configure stage. Includes meta.c changes by Steve
Whitehouse.
Signed-off-by:
Hi,
On Fri, 2014-02-14 at 12:05 +0300, Dan Carpenter wrote:
This patch moves the dereference of buffer after the check for NULL.
The only place which passes a NULL parameter is gfs2_set_acl().
Cc: stable sta...@vger.kernel.org
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
Al, are
Hi,
Now in the -nmw git tree. Thanks,
Steve.
On Thu, 2014-02-06 at 10:43 -0500, Bob Peterson wrote:
Hi,
This patch causes GFS2 to lock the i_mutex during fallocate. It
also switches from using a dinode's inode glock to using a local
holder like the other GFS2 i_operations.
Regards,
a problem in the past in the writeback code path, which
is why I've hesitated to do it here.
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index e0259a1..82a1456 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -94,6 +94,8 @@ static
.
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index 5c52418..ec455b9 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -376,12 +376,11 @@ static void munge_mode_uid_gid(const struct gfs2_inode
*dip,
inode-i_gid
Hi,
With the merge window now closed, I've updated the GFS2 -nmw git tree,
which now contains just one small patch,
Steve.
Hi,
Both patches look good to me,
Steve.
On Mon, 2014-02-03 at 14:25 +, Andrew Price wrote:
gfs2_edit savemeta wasn't converting sbd.fssize to bytes before converting it
to a human-friendly number. This patch adds that multiplier along with a
sanity
test for savemeta/restoremeta.
Hi,
On Mon, 2014-01-27 at 15:03 +, Andrew Price wrote:
On 27/01/14 14:47, Steven Whitehouse wrote:
Hi,
These look like a step in the right direction - however patch 5 seems to
be missing in the set that I received,
Hm strange, I didn't receive it either but it hit the archives
...@redhat.com
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index c8d6161..809fecd 100644
--- a/fs/gfs2/rgrp.c
+++ b/fs/gfs2/rgrp.c
@@ -57,6 +57,11 @@
* 3 = Used (metadata)
*/
+struct gfs2_extent {
+ struct gfs2_rbm rbm;
+ u32 len
Since gfs2_inplace_reserve() is always called with a valid
alloc parms structure, there is no need to test for this
within the function itself - and in any case, after we've
all ready dereferenced it anyway.
Reported-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Steven Whitehouse
skip_rgrp so that the
disqualified reservation is properly removed from the tree, thus keeping
the rgrp rd_reserved count sane.
Signed-off-by: Bob Peterson rpete...@redhat.com
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index 809fecd..1ccf89a
.
This will provide a performance improvement which will be
greater as the size of the directory increases.
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
index 0b6be20..d5988aa 100644
--- a/fs/gfs2/dir.c
+++ b/fs/gfs2/dir.c
@@ -1659,26 +1659,34 @@ static int
into a single function
rather than repeating it three times.
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index 9ac8f13..fa4624f 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -469,6 +469,28 @@ static void init_dinode(struct gfs2_inode *dip
this is no
longer used for its original role, it should be possible to
shrink the number of items on that list in due course and
remove the requirement to take qd_lock in qd_get.
Signed-off-by: Steven Whitehouse swhit...@redhat.com
Cc: Abhijith Das a...@redhat.com
Cc: Paul E. McKenney paul
From: Bob Peterson rpete...@redhat.com
This is a small cleanup to function gfs2_rgrp_go_lock so that it
uses rgd instead of its more complicated twin.
Signed-off-by: Bob Peterson rpete...@redhat.com
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2
to request the full reservation size in this case.
Potentially we could calculate more accurately the value to use
in other cases too, but that is much more complicated to do and
it is doubtful that the benefit would outweigh the extra cost
in code complexity.
Signed-off-by: Steven Whitehouse swhit
recent insertion/deletion.
For backwards compatibility, any of these new fields which is
zero should be considered to be unknown.
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
index b2e5ebf..fa32655 100644
--- a/fs/gfs2/dir.c
+++ b/fs/gfs2/dir.c
There is only one place this is used, when reading in the quota
changes at mount time. It is not really required and much
simpler to just convert the fields from the on-disk structure
as required.
There should be no functional change as a result of this patch.
Signed-off-by: Steven Whitehouse
Spotted by Andy Price. This should fix the odd messages from
lockdep caused by 70d4ee94b370c5ef54d0870600f16bd92d18013c
Signed-off-by: Steven Whitehouse swhit...@redhat.com
Cc: Andrew Price anpr...@redhat.com
diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
index 94aab31..3b820b6 100644
, with a vmalloc
fallback, just in case of memory fragmentation.
We are then able to use the kernel's own find/test/set/clear
bit functions, rather than rolling our own.
Signed-off-by: Steven Whitehouse swhit...@redhat.com
Cc: Abhijith Das a...@redhat.com
diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h
of unreachable code and make this more
readable.
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
index 73f3e4e..cf858da 100644
--- a/fs/gfs2/aops.c
+++ b/fs/gfs2/aops.c
@@ -1080,30 +1080,22 @@ int gfs2_releasepage(struct page *page, gfp_t gfp_mask
a bug where the link used during
inode creation was adding requesting too many blocks in
some cases. This is harmless unless the fs is close to being
full.
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
index 2e5fc26..0b6be20 100644
--- a/fs/gfs2/dir.c
)) and since
we don't support STREAMS it's probably fair game, but... what the hell?
Signed-off-by: Steven Whitehouse swhit...@redhat.com
Cc: Al Viro v...@zeniv.linux.org.uk
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index 6f7a47c..ca0be6c 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
declaration of function 'vfree'
[-Werror=implicit-function-declaration]
vfree(sdp-sd_quota_bitmap);
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c
index 02a2740..8bec0e31 100644
--- a/fs/gfs2/quota.c
+++ b/fs/gfs2/quota.c
@@ -56,6 +56,7
From ac3beb6a5de048e7c0676f630ad2048a7b37b305 Mon Sep 17 00:00:00 2001
From: Steven Whitehouse swhit...@redhat.com
Date: Thu, 16 Jan 2014 10:31:13 +
Subject: GFS2: Don't use ENOBUFS when ENOMEM is the correct error code
Al Viro has tactfully pointed out that we are using the incorrect
error
From 1e3d36206bd6dfa34c85b073faba3d94ee6aba79 Mon Sep 17 00:00:00 2001
From: Steven Whitehouse swhit...@redhat.com
Date: Wed, 15 Jan 2014 12:57:25 +
Subject: GFS2: Fix kbuild test robot reported warning
Well I don't get the same warning locally as the kbuild
robot, but I guess this should fix
From 086352f1aa8d717eaf565074d6634c7bdd26aca0 Mon Sep 17 00:00:00 2001
From: Steven Whitehouse swhit...@redhat.com
Date: Tue, 14 Jan 2014 13:46:51 +
Subject: GFS2: No need to invalidate pages for a dio read
We recently fixed the writeback of pages prior to performing
direct i/o, however
From 39849d6946a84861a517c09ca0b691ce6d98c7a6 Mon Sep 17 00:00:00 2001
From: Steven Whitehouse swhit...@redhat.com
Date: Thu, 9 Jan 2014 16:34:04 +
Subject: GFS2: Add initialization for address space in super block
Spotted by Andy Price. This should fix the odd messages from
lockdep caused
From 22b5a6c0c0cd5eb524d31c949d113c6683e37ec9 Mon Sep 17 00:00:00 2001
From: Steven Whitehouse swhit...@redhat.com
Date: Wed, 8 Jan 2014 11:05:29 +
Subject: GFS2: For exhash conversion, only one block is needed
For most cases, only a single new block is needed when we reach
the point
Hi,
I've added this to the -nmw git tree. Thanks,
Steve.
On Mon, 2014-01-06 at 17:16 -0500, Bob Peterson wrote:
Hi,
This patch calls get_write_access in function gfs2_setattr_chown,
which merely increases inode-i_writecount for the duration of the
function. That will ensure that any file
From 3c1c0ae1db74b1f3e606f42158b5dadd89105c1f Mon Sep 17 00:00:00 2001
From: Steven Whitehouse swhit...@redhat.com
Date: Mon, 6 Jan 2014 11:28:41 +
Subject: GFS2: Add directory addition info structure
The intent is that this structure will hold the information
required when adding entries
From 2b47dad866d04f14c328f888ba5406057b8c7d33 Mon Sep 17 00:00:00 2001
From: Steven Whitehouse swhit...@redhat.com
Date: Mon, 6 Jan 2014 12:49:43 +
Subject: GFS2: Remember directory insert point
When we look to see if there is enough space to add a dir
entry without allocation, we have
From 534cf9ca553953e4c12fa5f0d23e543f9a6ccbaf Mon Sep 17 00:00:00 2001
From: Steven Whitehouse swhit...@redhat.com
Date: Mon, 6 Jan 2014 12:03:05 +
Subject: GFS2: Consolidate transaction blocks calculation for dir add
There are three cases where we need to calculate the number of
blocks
Hi,
Linus has pulled the fixes that I sent him yesterday, so I've rebased
the remaining GFS2 patches in -nmw on the latest upstream kernel as
usual,
Steve.
, because
multiple processes can call gfs2_remove_from_journal. In order to
avoid double-frees, only the process that does the unpinning is
allowed to free the bd.
Signed-off-by: Bob Peterson rpete...@redhat.com
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/meta_io.c b/fs
...@kernel.org
Reported-by: Al Viro v...@zeniv.linux.org.uk
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
index 82303b4..52fa883 100644
--- a/fs/gfs2/ops_fstype.c
+++ b/fs/gfs2/ops_fstype.c
@@ -1366,8 +1366,18 @@ static struct dentry
in kmem_cache_destroy(): cache `gfs2_bufdata': Can't free all objects
Signed-off-by: Bob Peterson rpete...@redhat.com
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c
index 610613f..9dcb977 100644
--- a/fs/gfs2/log.c
+++ b/fs/gfs2/log.c
@@ -551,10 +551,10
to unmap, flush
and invalidate those pages. Since the glock state machine
normally does that for us, mostly the code will be a no-op.
Signed-off-by: Steven Whitehouse swhit...@redhat.com
diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
index b7fc035..73f3e4e 100644
--- a/fs/gfs2/aops.c
+++ b/fs/gfs2/aops.c
From: Tetsuo Handa penguin-ker...@i-love.sakura.ne.jp
GLOCK_BUG_ON() might call this function without RCU read lock. Make sure that
RCU read lock is held when using task_struct returned from pid_task().
Signed-off-by: Tetsuo Handa penguin-ker...@i-love.sakura.ne.jp
Signed-off-by: Steven
Hi,
Here is a set of small fixes for GFS2. There is a fix to drop
s_umount which is copied in from the core vfs, two patches
relate to a hard to hit use after free and memory leak.
Two patches related to using DIO and buffered I/O on the same
file to ensure correct operation in relation to glock
401 - 500 of 2062 matches
Mail list logo
