Re: [Cluster-devel] [DLM PATCH 3/6] DLM: Make consistent error path

2016-02-11 Thread Andreas Gruenbacher
Bob, On Thu, Feb 11, 2016 at 6:59 PM, Bob Peterson wrote: > - Original Message - >> > +out_err: >> > + sock_release(sock); >> > + sock = NULL; >> > + con->sock = NULL; >> >> Consolidating the error paths makes sense, but con->sock shouldn't be >> set here at all; the cal

Re: [Cluster-devel] [DLM PATCH 3/6] DLM: Make consistent error path through tcp_create_listen_sock

2016-02-11 Thread Bob Peterson
- Original Message - > > +out_err: > > + sock_release(sock); > > + sock = NULL; > > + con->sock = NULL; > > Consolidating the error paths makes sense, but con->sock shouldn't be > set here at all; the caller does that in add_sock(). > > Thanks, > Andreas > Hi Andreas,

Re: [Cluster-devel] [DLM PATCH 3/6] DLM: Make consistent error path through tcp_create_listen_sock

2016-02-11 Thread Andreas Gruenbacher
On Wed, Feb 10, 2016 at 7:55 PM, Bob Peterson wrote: > Function tcp_create_listen_sock has two error paths. One of them > was setting con->sock to NULL. The other was not. This patch changes > it to be consistent and do the same thing for both error paths. > > Signed-off-by: Bob Peterson > --- >

[Cluster-devel] [DLM PATCH 3/6] DLM: Make consistent error path through tcp_create_listen_sock

2016-02-10 Thread Bob Peterson
Function tcp_create_listen_sock has two error paths. One of them was setting con->sock to NULL. The other was not. This patch changes it to be consistent and do the same thing for both error paths. Signed-off-by: Bob Peterson --- fs/dlm/lowcomms.c | 16 +--- 1 file changed, 9 inserti