Re: [Cluster-devel] [PATCH] Revert "gfs2: stop using generic_writepages in gfs2_ail1_start_one"

2023-01-22 Thread Andreas Gruenbacher
On Sat, Jan 21, 2023 at 3:29 PM Christoph Hellwig wrote: > > > + struct address_space *mapping = data; > > + int ret = mapping->a_ops->writepage(page, wbc); > > + mapping_set_error(mapping, ret); > > + return ret; > > I guess beggars can't be choosers, but is there a chance to

Re: [Cluster-devel] [PATCH] Revert "gfs2: stop using generic_writepages in gfs2_ail1_start_one"

2023-01-21 Thread Christoph Hellwig
> + struct address_space *mapping = data; > + int ret = mapping->a_ops->writepage(page, wbc); > + mapping_set_error(mapping, ret); > + return ret; I guess beggars can't be choosers, but is there a chance to directly call the relevant gfs2 writepage methods here instead of the

[Cluster-devel] [PATCH] Revert "gfs2: stop using generic_writepages in gfs2_ail1_start_one"

2023-01-20 Thread Andreas Gruenbacher
Commit b2b0a5e97855 switched from generic_writepages() to filemap_fdatawrite_wbc() in gfs2_ail1_start_one() on the path to replacing ->writepage() with ->writepages() and eventually eliminating the former. Function gfs2_ail1_start_one() is called from gfs2_log_flush(), our main function for