Re: [Cluster-devel] [PATCH] direct-io: Prevent NULL pointer access in submit_page_section

2017-10-09 Thread Andreas Gruenbacher
On 9 October 2017 at 18:22, Al Viro wrote: > On Mon, Oct 09, 2017 at 11:13:18AM +0200, Andreas Gruenbacher wrote: >> In the code added to function submit_page_section by commit b1058b981, >> sdio->bio can currently be NULL when calling dio_bio_submit. This then >> leads

Re: [Cluster-devel] [PATCH] direct-io: Prevent NULL pointer access in submit_page_section

2017-10-09 Thread Al Viro
On Mon, Oct 09, 2017 at 11:13:18AM +0200, Andreas Gruenbacher wrote: > In the code added to function submit_page_section by commit b1058b981, > sdio->bio can currently be NULL when calling dio_bio_submit. This then > leads to a NULL pointer access in dio_bio_submit, so check for a NULL > bio in

[Cluster-devel] [PATCH] direct-io: Prevent NULL pointer access in submit_page_section

2017-10-09 Thread Andreas Gruenbacher
In the code added to function submit_page_section by commit b1058b981, sdio->bio can currently be NULL when calling dio_bio_submit. This then leads to a NULL pointer access in dio_bio_submit, so check for a NULL bio in submit_page_section before trying to submit it instead. Fixes xfstest