Re: [Cluster-devel] [PATCH 21/21] hfsplus: remove can_set_xattr

2014-01-05 Thread Vyacheslav Dubeyko
On Sun, 2013-12-22 at 11:28 -0800, Christoph Hellwig wrote: - if (!strncmp(name, XATTR_MAC_OSX_PREFIX, XATTR_MAC_OSX_PREFIX_LEN)) { - /* - * This makes sure that we aren't trying to set an - * attribute in a different namespace by prefixing it -

Re: [Cluster-devel] [PATCH 21/21] hfsplus: remove can_set_xattr

2014-01-05 Thread Vyacheslav Dubeyko
On Mon, 2013-12-23 at 06:37 -0800, Christoph Hellwig wrote: On Mon, Dec 23, 2013 at 10:40:09AM +0400, Vyacheslav Dubeyko wrote: Maybe I missed something, but I can see that this check is removed only. Could you point out the code in your patch that it checks and forbids such combination as

Re: [Cluster-devel] [PATCH 21/21] hfsplus: remove can_set_xattr

2013-12-22 Thread Christoph Hellwig
On Sat, Dec 21, 2013 at 08:07:51PM +0300, Vyacheslav Dubeyko wrote: -static int can_set_xattr(struct inode *inode, const char *name, - const void *value, size_t value_len) This function works for all handlers. So, I don't think that it makes sense to delete it.

Re: [Cluster-devel] [PATCH 21/21] hfsplus: remove can_set_xattr

2013-12-21 Thread Vyacheslav Dubeyko
On Dec 20, 2013, at 4:16 PM, Christoph Hellwig wrote: When using the per-superblock xattr handlers permission checking is done by the generic code. hfsplus just needs to check for the magic osx attribute not to leak into protected namespaces. Also given that the code was obviously copied

[Cluster-devel] [PATCH 21/21] hfsplus: remove can_set_xattr

2013-12-20 Thread Christoph Hellwig
When using the per-superblock xattr handlers permission checking is done by the generic code. hfsplus just needs to check for the magic osx attribute not to leak into protected namespaces. Also given that the code was obviously copied from JFS the proper attribution was missing. Signed-off-by: