Re: [Cluster-devel] [PATCH 3/6] gfs2: Convert gfs2_write_jdata_page() to gfs2_write_jdata_folio()

2023-06-04 Thread Andreas Gruenbacher
On Sun, Jun 4, 2023 at 5:38 AM Matthew Wilcox wrote: > > On Sat, Jun 03, 2023 at 11:34:14AM +0200, Andreas Gruenbacher wrote: > > > * This is the same as calling block_write_full_page, but it also > > > * writes pages outside of i_size > > > */ > > > -static int gfs2_write_jdata_page(struct

Re: [Cluster-devel] [PATCH 3/6] gfs2: Convert gfs2_write_jdata_page() to gfs2_write_jdata_folio()

2023-06-03 Thread Matthew Wilcox
On Sat, Jun 03, 2023 at 11:34:14AM +0200, Andreas Gruenbacher wrote: > > * This is the same as calling block_write_full_page, but it also > > * writes pages outside of i_size > > */ > > -static int gfs2_write_jdata_page(struct page *page, > > +static int gfs2_write_jdata_folio(struct folio

Re: [Cluster-devel] [PATCH 3/6] gfs2: Convert gfs2_write_jdata_page() to gfs2_write_jdata_folio()

2023-06-03 Thread Andreas Gruenbacher
Hi Willy, thanks for these patches. This particular one looks problematic: On Wed, May 17, 2023 at 5:24 AM Matthew Wilcox (Oracle) wrote: > This function now supports large folios, even if nothing around it does. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > fs/gfs2/aops.c | 27

[Cluster-devel] [PATCH 3/6] gfs2: Convert gfs2_write_jdata_page() to gfs2_write_jdata_folio()

2023-05-16 Thread Matthew Wilcox (Oracle)
This function now supports large folios, even if nothing around it does. Signed-off-by: Matthew Wilcox (Oracle) --- fs/gfs2/aops.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c index 749135252d52..0f92e3e117da