Re: [Cluster-devel] [PATCH dlm-tool 13/14] dlm_controld: plock log lock state

2023-03-03 Thread Alexander Aring
Hi, On Fri, Mar 3, 2023 at 5:20 PM Alexander Aring wrote: > > Hi, > > On Fri, Mar 3, 2023 at 11:08 AM Andreas Gruenbacher > wrote: > > > > On Fri, Mar 3, 2023 at 4:53 PM Andreas Gruenbacher > > wrote: > > > diff --git a/dlm_controld/plock.c b/dlm_controld/plock.c > > > index

Re: [Cluster-devel] [PATCH dlm-tool 13/14] dlm_controld: plock log lock state

2023-03-03 Thread Alexander Aring
Hi, On Fri, Mar 3, 2023 at 5:20 PM Alexander Aring wrote: > > Hi, > > On Fri, Mar 3, 2023 at 11:08 AM Andreas Gruenbacher > wrote: > > > > On Fri, Mar 3, 2023 at 4:53 PM Andreas Gruenbacher > > wrote: > > > diff --git a/dlm_controld/plock.c b/dlm_controld/plock.c > > > index

Re: [Cluster-devel] [PATCH dlm-tool 13/14] dlm_controld: plock log lock state

2023-03-03 Thread Alexander Aring
Hi, On Fri, Mar 3, 2023 at 10:52 AM Andreas Gruenbacher wrote: > > Now, let me get to the core of the matter. We've been talking about > using user-space (SDT) trace points for collecting the data, and I still > think that that's what we should do instead of introducing a new > dlm_controld log

Re: [Cluster-devel] [PATCH dlm-tool 13/14] dlm_controld: plock log lock state

2023-03-03 Thread Alexander Aring
Hi, On Fri, Mar 3, 2023 at 11:08 AM Andreas Gruenbacher wrote: > > On Fri, Mar 3, 2023 at 4:53 PM Andreas Gruenbacher > wrote: > > diff --git a/dlm_controld/plock.c b/dlm_controld/plock.c > > index 39bdd1f6..588bcaaa 100644 > > --- a/dlm_controld/plock.c > > +++ b/dlm_controld/plock.c > > @@

Re: [Cluster-devel] [PATCH dlm-tool 13/14] dlm_controld: plock log lock state

2023-03-03 Thread Andreas Gruenbacher
On Fri, Mar 3, 2023 at 4:53 PM Andreas Gruenbacher wrote: > diff --git a/dlm_controld/plock.c b/dlm_controld/plock.c > index 39bdd1f6..588bcaaa 100644 > --- a/dlm_controld/plock.c > +++ b/dlm_controld/plock.c > @@ -8,6 +8,7 @@ > > #include "dlm_daemon.h" > #include > +#include > > /* FIXME:

Re: [Cluster-devel] [PATCH dlm-tool 13/14] dlm_controld: plock log lock state

2023-03-03 Thread Andreas Gruenbacher
Now, let me get to the core of the matter. We've been talking about using user-space (SDT) trace points for collecting the data, and I still think that that's what we should do instead of introducing a new dlm_controld log file. In the dlm_controld code, this would look like the below patch.

Re: [Cluster-devel] [PATCH dlm-tool 13/14] dlm_controld: plock log lock state

2023-03-03 Thread Alexander Aring
Hi, On Fri, Mar 3, 2023 at 8:38 AM Andreas Gruenbacher wrote: > > Alexx, > > can you please prefix this patch with the following to make this easier > to read? > okay. btw: I think we could make a struct lockspace pointer in struct resource which is all the way passed down. I think a struct

Re: [Cluster-devel] [PATCH dlm-tool 13/14] dlm_controld: plock log lock state

2023-03-03 Thread Andreas Gruenbacher
Alexx, can you please prefix this patch with the following to make this easier to read? Thanks, Andreas -- dlm_controld: pass lockspace and lock number to add_lock() The next patch will make use of the additional arguments. --- dlm_controld/plock.c | 41

[Cluster-devel] [PATCH dlm-tool 13/14] dlm_controld: plock log lock state

2023-03-02 Thread Alexander Aring
This patch adds additional log_plock() calls to track the start and end of lock states inside the dlm_controld lock database. With this information we know when a specific lock had a specfic lock mode (WR or RD) in use as in view of dlm_controld cluster-wide plock view. --- dlm_controld/plock.c |