Re: [Cluster-devel] [PATCH v2 1/2] iomap: Don't create iomap_page objects for inline files

2021-07-06 Thread Andreas Gruenbacher
On Tue, Jul 6, 2021 at 7:07 AM Christoph Hellwig wrote: > On Mon, Jul 05, 2021 at 08:18:23PM +0200, Andreas Gruenbacher wrote: > > In iomap_readpage_actor, don't create iop objects for inline inodes. > > Otherwise, iomap_read_inline_data will set PageUptodate without setting > > iop->uptodate, and

Re: [Cluster-devel] [PATCH v2 1/2] iomap: Don't create iomap_page objects for inline files

2021-07-05 Thread Christoph Hellwig
On Mon, Jul 05, 2021 at 08:18:23PM +0200, Andreas Gruenbacher wrote: > In iomap_readpage_actor, don't create iop objects for inline inodes. > Otherwise, iomap_read_inline_data will set PageUptodate without setting > iop->uptodate, and iomap_page_release will eventually complain. > > To prevent thi

[Cluster-devel] [PATCH v2 1/2] iomap: Don't create iomap_page objects for inline files

2021-07-05 Thread Andreas Gruenbacher
In iomap_readpage_actor, don't create iop objects for inline inodes. Otherwise, iomap_read_inline_data will set PageUptodate without setting iop->uptodate, and iomap_page_release will eventually complain. To prevent this kind of bug from occurring in the future, make sure the page doesn't have pri