Re: [Cluster-devel] [PATCH v2 13/14] ext2: replace bh_submit_read() helper with bh_read_locked()

2022-09-04 Thread Christoph Hellwig
Looks good: Reviewed-by: Christoph Hellwig

Re: [Cluster-devel] [PATCH v2 13/14] ext2: replace bh_submit_read() helper with bh_read_locked()

2022-09-01 Thread Al Viro
On Fri, Sep 02, 2022 at 09:32:53AM +0800, Zhang Yi wrote: > On 2022/9/2 8:30, Al Viro wrote: > > On Thu, Sep 01, 2022 at 09:35:04PM +0800, Zhang Yi wrote: > >> bh_submit_read() and the uptodate check logic in bh_uptodate_or_lock() > >> has been integrated in bh_read() helper, so switch to use it di

Re: [Cluster-devel] [PATCH v2 13/14] ext2: replace bh_submit_read() helper with bh_read_locked()

2022-09-01 Thread Al Viro
On Thu, Sep 01, 2022 at 09:35:04PM +0800, Zhang Yi wrote: > bh_submit_read() and the uptodate check logic in bh_uptodate_or_lock() > has been integrated in bh_read() helper, so switch to use it directly. s/bh_read_locked/bh_read/ in the summary?

Re: [Cluster-devel] [PATCH v2 13/14] ext2: replace bh_submit_read() helper with bh_read_locked()

2022-09-01 Thread Jan Kara
On Thu 01-09-22 21:35:04, Zhang Yi wrote: > bh_submit_read() and the uptodate check logic in bh_uptodate_or_lock() > has been integrated in bh_read() helper, so switch to use it directly. > > Signed-off-by: Zhang Yi Looks good to me. Feel free to add: Reviewed-by: Jan Kara