Re: [Cluster-devel] [PATCH v3 1/2] iomap: Add a page_prepare callback

2019-04-26 Thread Andreas Gruenbacher
On Fri, 26 Apr 2019 at 10:30, Jan Kara wrote: > > On Thu 25-04-19 18:09:12, Andreas Gruenbacher wrote: > > Move the page_done callback into a separate iomap_page_ops structure and > > add a page_prepare calback to be called before a page is written to. In > > gfs2, we'll want to start a transacti

Re: [Cluster-devel] [PATCH v3 1/2] iomap: Add a page_prepare callback

2019-04-26 Thread Jan Kara
On Thu 25-04-19 18:09:12, Andreas Gruenbacher wrote: > Move the page_done callback into a separate iomap_page_ops structure and > add a page_prepare calback to be called before a page is written to. In > gfs2, we'll want to start a transaction in page_prepare and end it in > page_done, and other f

Re: [Cluster-devel] [PATCH v3 1/2] iomap: Add a page_prepare callback

2019-04-25 Thread kbuild test robot
Hi Andreas, I love your patch! Yet something to improve: [auto build test ERROR on gfs2/for-next] [also build test ERROR on v5.1-rc6 next-20190424] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commit

[Cluster-devel] [PATCH v3 1/2] iomap: Add a page_prepare callback

2019-04-25 Thread Andreas Gruenbacher
Move the page_done callback into a separate iomap_page_ops structure and add a page_prepare calback to be called before a page is written to. In gfs2, we'll want to start a transaction in page_prepare and end it in page_done, and other filesystems that implement data journaling will require the sa