Re: [Cluster-devel] [PATCH v6 3/4] iomap: Add a page_prepare callback

2019-04-29 Thread Jan Kara
On Mon 29-04-19 18:32:38, Andreas Gruenbacher wrote: > Move the page_done callback into a separate iomap_page_ops structure and > add a page_prepare calback to be called before the next page is written > to. In gfs2, we'll want to start a transaction in page_prepare and end > it in page_done.

Re: [Cluster-devel] [PATCH v6 3/4] iomap: Add a page_prepare callback

2019-04-29 Thread Christoph Hellwig
> +static int gfs2_iomap_page_prepare(struct inode *inode, loff_t pos, > +unsigned len, struct iomap *iomap) > +{ > + return 0; > +} Now that we check for each callback there is no need to add a dummy one in this patch. But given that that won't change the end

[Cluster-devel] [PATCH v6 3/4] iomap: Add a page_prepare callback

2019-04-29 Thread Andreas Gruenbacher
Move the page_done callback into a separate iomap_page_ops structure and add a page_prepare calback to be called before the next page is written to. In gfs2, we'll want to start a transaction in page_prepare and end it in page_done. Other filesystems that implement data journaling will require