Re: [Cluster-devel] [REPORT] kernel BUG at fs/ext4/inode.c:2620 - page_buffers()

2022-02-24 Thread Dave Chinner
On Wed, Feb 23, 2022 at 10:50:09PM -0500, Theodore Ts'o wrote: > On Thu, Feb 24, 2022 at 12:48:42PM +1100, Dave Chinner wrote: > > > Fair enough; on the other hand, we could also view this as making ext4 > > > more robust against buggy code in other subsystems, and while other > > > file systems

Re: [Cluster-devel] [REPORT] kernel BUG at fs/ext4/inode.c:2620 - page_buffers()

2022-02-23 Thread Theodore Ts'o
On Wed, Feb 23, 2022 at 04:44:07PM -0800, John Hubbard wrote: > > Actually...I can confirm that real customers really are doing *exactly* > that! Despite the kernel crashes--because the crashes don't always > happen unless you have a large (supercomputer-sized) installation. And > even then it

Re: [Cluster-devel] [REPORT] kernel BUG at fs/ext4/inode.c:2620 - page_buffers()

2022-02-23 Thread Theodore Ts'o
On Thu, Feb 24, 2022 at 12:48:42PM +1100, Dave Chinner wrote: > > Fair enough; on the other hand, we could also view this as making ext4 > > more robust against buggy code in other subsystems, and while other > > file systems may be losing user data if they are actually trying to do > > remote

Re: [Cluster-devel] [REPORT] kernel BUG at fs/ext4/inode.c:2620 - page_buffers()

2022-02-23 Thread Dave Chinner
On Wed, Feb 23, 2022 at 06:35:54PM -0500, Theodore Ts'o wrote: > On Fri, Feb 18, 2022 at 08:51:54AM +0100, Greg Kroah-Hartman wrote: > > > The challenge is that fixing this "the right away" is probably not > > > something we can backport into an LTS kernel, whether it's 5.15 or > > > 5.10... or

Re: [Cluster-devel] [REPORT] kernel BUG at fs/ext4/inode.c:2620 - page_buffers()

2022-02-23 Thread Theodore Ts'o
On Fri, Feb 18, 2022 at 08:51:54AM +0100, Greg Kroah-Hartman wrote: > > The challenge is that fixing this "the right away" is probably not > > something we can backport into an LTS kernel, whether it's 5.15 or > > 5.10... or 4.19. > > Don't worry about stable backports to start with. Do it the

Re: [Cluster-devel] [REPORT] kernel BUG at fs/ext4/inode.c:2620 - page_buffers()

2022-02-23 Thread Theodore Ts'o
On Thu, Feb 17, 2022 at 10:33:34PM -0800, John Hubbard wrote: > > Just a small thing I'll say once, to get it out of my system. No action > required here, I just want it understood: > > Before commit 803e4572d7c5 ("mm/process_vm_access: set FOLL_PIN via > pin_user_pages_remote()"), you would

Re: [Cluster-devel] [REPORT] kernel BUG at fs/ext4/inode.c:2620 - page_buffers()

2022-02-17 Thread Greg Kroah-Hartman
On Thu, Feb 17, 2022 at 11:08:38PM -0500, Theodore Ts'o wrote: > On Thu, Feb 17, 2022 at 05:06:45PM -0800, John Hubbard wrote: > > Yes. And looking at the pair of backtraces below, this looks very much > > like another aspect of the "get_user_pages problem" [1], originally > > described in Jan

Re: [Cluster-devel] [REPORT] kernel BUG at fs/ext4/inode.c:2620 - page_buffers()

2022-02-17 Thread Theodore Ts'o
On Fri, Feb 18, 2022 at 04:24:20AM +, Matthew Wilcox wrote: > On Thu, Feb 17, 2022 at 09:54:30PM -0500, Theodore Ts'o wrote: > > process_vm_writev() uses [un]pin_user_pages_remote() which is the same > > interface uses for RDMA. But it's not clear this is ever supposed to > > work for memory

Re: [Cluster-devel] [REPORT] kernel BUG at fs/ext4/inode.c:2620 - page_buffers()

2022-02-17 Thread Matthew Wilcox
On Thu, Feb 17, 2022 at 09:54:30PM -0500, Theodore Ts'o wrote: > process_vm_writev() uses [un]pin_user_pages_remote() which is the same > interface uses for RDMA. But it's not clear this is ever supposed to > work for memory which is mmap'ed region backed by a file. > pin_user_pages_remote()

Re: [Cluster-devel] [REPORT] kernel BUG at fs/ext4/inode.c:2620 - page_buffers()

2022-02-17 Thread Theodore Ts'o
On Thu, Feb 17, 2022 at 05:06:45PM -0800, John Hubbard wrote: > Yes. And looking at the pair of backtraces below, this looks very much > like another aspect of the "get_user_pages problem" [1], originally > described in Jan Kara's 2018 email [2]. Hmm... I just posted my analysis, which tracks

Re: [Cluster-devel] [REPORT] kernel BUG at fs/ext4/inode.c:2620 - page_buffers()

2022-02-17 Thread Theodore Ts'o
On Wed, Feb 16, 2022 at 04:31:36PM +, Lee Jones wrote: > > After recently receiving a bug report from Syzbot [0] which was raised > specifically against the Android v5.10 kernel, I spent some time > trying to get to the crux. Firstly I reproduced the issue on the > reported kernel, then did

[Cluster-devel] [REPORT] kernel BUG at fs/ext4/inode.c:2620 - page_buffers()

2022-02-16 Thread Lee Jones
Good afternoon, After recently receiving a bug report from Syzbot [0] which was raised specifically against the Android v5.10 kernel, I spent some time trying to get to the crux. Firstly I reproduced the issue on the reported kernel, then did the same using the latest release kernel v5.16. The