Re: [Cluster-devel] [RFC v3 5/7] iomap: Get page in page_prepare handler

2022-12-23 Thread Christoph Hellwig
On Fri, Dec 16, 2022 at 04:06:24PM +0100, Andreas Gruenbacher wrote: > Change the iomap ->page_prepare() handler to get and return a locked > folio instead of doing that in iomap_write_begin(). This allows to > recover from out-of-memory situations in ->page_prepare(), which > eliminates the corre

Re: [Cluster-devel] [RFC v3 5/7] iomap: Get page in page_prepare handler

2022-12-16 Thread Andreas Gruenbacher
On Fri, Dec 16, 2022 at 5:30 PM Matthew Wilcox wrote: > On Fri, Dec 16, 2022 at 04:06:24PM +0100, Andreas Gruenbacher wrote: > > + if (page_ops && page_ops->page_prepare) > > + folio = page_ops->page_prepare(iter, pos, len); > > + else > > + folio = iomap_folio_prep

Re: [Cluster-devel] [RFC v3 5/7] iomap: Get page in page_prepare handler

2022-12-16 Thread Matthew Wilcox
On Fri, Dec 16, 2022 at 04:06:24PM +0100, Andreas Gruenbacher wrote: > + if (page_ops && page_ops->page_prepare) > + folio = page_ops->page_prepare(iter, pos, len); > + else > + folio = iomap_folio_prepare(iter, pos); > + if (IS_ERR_OR_NULL(folio)) { > +

[Cluster-devel] [RFC v3 5/7] iomap: Get page in page_prepare handler

2022-12-16 Thread Andreas Gruenbacher
Change the iomap ->page_prepare() handler to get and return a locked folio instead of doing that in iomap_write_begin(). This allows to recover from out-of-memory situations in ->page_prepare(), which eliminates the corresponding error handling code in iomap_write_begin(). The ->page_done() handle