Re: [Cluster-devel] [bug report] GFS2: Use resizable hash table for glocks

2016-12-14 Thread Dan Carpenter
:/ I'm not a fan of this patch at all. Let me send my take on this and you can pick whichever you prefer. regards, dan carpenter

Re: [Cluster-devel] [bug report] GFS2: Use resizable hash table for glocks

2016-12-14 Thread Dan Carpenter
On Wed, Dec 14, 2016 at 08:41:57AM -0500, Bob Peterson wrote: > Hi Dan, > > - Original Message - > | Hello Bob Peterson, > | > | The patch 88ffbf3e037e: "GFS2: Use resizable hash table for glocks" > | from Mar 16, 2015, leads to the following static checker warning: > | > |

Re: [Cluster-devel] [bug report] GFS2: Use resizable hash table for glocks

2016-12-14 Thread Bob Peterson
- Original Message - | Hi Dan, | | - Original Message - | | Hello Bob Peterson, | | | | The patch 88ffbf3e037e: "GFS2: Use resizable hash table for glocks" | | from Mar 16, 2015, leads to the following static checker warning: | | | | fs/gfs2/glock.c:1813

Re: [Cluster-devel] [bug report] GFS2: Use resizable hash table for glocks

2016-12-14 Thread Bob Peterson
Hi Dan, - Original Message - | Hello Bob Peterson, | | The patch 88ffbf3e037e: "GFS2: Use resizable hash table for glocks" | from Mar 16, 2015, leads to the following static checker warning: | | fs/gfs2/glock.c:1813 gfs2_glock_iter_next() | error: 'gi->gl' dereferencing

[Cluster-devel] [bug report] GFS2: Use resizable hash table for glocks

2016-12-14 Thread Dan Carpenter
Hello Bob Peterson, The patch 88ffbf3e037e: "GFS2: Use resizable hash table for glocks" from Mar 16, 2015, leads to the following static checker warning: fs/gfs2/glock.c:1813 gfs2_glock_iter_next() error: 'gi->gl' dereferencing possible ERR_PTR() fs/gfs2/glock.c 1803 static