Re: [Cluster-devel] Question on LVB when the node that held EX lock crash

2016-12-01 Thread Eric Ren
Hi David, On 12/01/2016 12:16 AM, David Teigland wrote: On Wed, Nov 30, 2016 at 05:07:22PM +0800, Eric Ren wrote: a. Should we put recover_lvb() even before recover_conversion()? if not, why? Yes, I think you're right. The lvb decision should be made using the original lock modes, not the

Re: [Cluster-devel] Question on LVB when the node that held EX lock crash

2016-11-30 Thread David Teigland
On Wed, Nov 30, 2016 at 05:07:22PM +0800, Eric Ren wrote: > @@ -852,12 +868,19 @@ void dlm_recover_rsbs(struct dlm_ls *ls) > if (is_master(r)) { > if (rsb_flag(r, RSB_RECOVER_CONVERT)) > recover_conversion(r); > + > +

Re: [Cluster-devel] Question on LVB when the node that held EX lock crash

2016-11-30 Thread Eric Ren
Hi David, On 11/16/2016 11:08 PM, David Teigland wrote: convert(R1, EX) get LVB Qustion: what is the LVB then? x or y? == Is this a valid question? or am I missing something? It's a good question, and it's been enough years that the details are now hazy. I think the current behavior

Re: [Cluster-devel] Question on LVB when the node that held EX lock crash

2016-11-17 Thread Eric Ren
Hi! On 11/16/2016 11:08 PM, David Teigland wrote: convert(R1, EX) get LVB Qustion: what is the LVB then? x or y? == Is this a valid question? or am I missing something? It's a good question, and it's been enough years that the details are now hazy. I think the current behavior

Re: [Cluster-devel] Question on LVB when the node that held EX lock crash

2016-11-16 Thread David Teigland
On Wed, Nov 16, 2016 at 04:42:09PM +0800, Eric Ren wrote: > On 11/16/2016 04:29 PM, Eric Ren wrote: > > Hi David and all, > > > > I am debugging an issue of ocfs2 that relates to LVB value. I will try > > to make it a pure DLM question: > > > > Two nodes (N1, N2) try to truncate the same

Re: [Cluster-devel] Question on LVB when the node that held EX lock crash

2016-11-16 Thread Eric Ren
On 11/16/2016 04:29 PM, Eric Ren wrote: Hi David and all, I am debugging an issue of ocfs2 that relates to LVB value. I will try to make it a pure DLM question: Two nodes (N1, N2) try to truncate the same file(R1) concurrently. N1 N2 lock(R1, EX)

[Cluster-devel] Question on LVB when the node that held EX lock crash

2016-11-16 Thread Eric Ren
Hi David and all, I am debugging an issue of ocfs2 that relates to LVB value. I will try to make it a pure DLM question: Two nodes (N1, N2) try to truncate the same file(R1) concurrently. N1 N2 lock(R1, EX) changing LVB: x