Re: [Cluster-devel] [PATCH v2 1/2] gfs2: Convert gfs2 to fs_context

2019-03-21 Thread David Howells
Andrew Price wrote: > Would this fly? Can you update the comment to document what it's for? David

Re: [Cluster-devel] [PATCH v2 1/2] gfs2: Convert gfs2 to fs_context

2019-03-21 Thread Andrew Price
On 19/03/2019 17:53, Andrew Price wrote: On 19/03/2019 17:05, David Howells wrote: Can you use vfs_get_block_super()? It might be possible if we can rearrange things so that this can be done outside of the function:     if (args->ar_meta)     fc->root =

Re: [Cluster-devel] [PATCH v2 1/2] gfs2: Convert gfs2 to fs_context

2019-03-19 Thread Andrew Price
On 19/03/2019 17:05, David Howells wrote: Andrew Price wrote: + pr_warn("-o debug and -o errors=panic are mutually exclusive\n"); + return -EINVAL; return invalf(fc, "gfs2: -o debug and -o errors=panic are mutually exclusive"); Thanks.

Re: [Cluster-devel] [PATCH v2 1/2] gfs2: Convert gfs2 to fs_context

2019-03-19 Thread David Howells
Andrew Price wrote: > + pr_warn("-o debug and -o errors=panic are mutually > exclusive\n"); > + return -EINVAL; return invalf(fc, "gfs2: -o debug and -o errors=panic are mutually exclusive"); (Note: no "\n") > + if (result.int_32 > 0) > +