Re: [Cluster-devel] [RFC 0/2] refcount: attempt to avoid imbalance warnings

2022-07-01 Thread Alexander Aring
Hi, On Fri, Jul 1, 2022 at 8:07 AM Alexander Aring wrote: > > Hi, > > On Thu, Jun 30, 2022 at 12:34 PM Linus Torvalds > wrote: > > > > On Thu, Jun 30, 2022 at 6:59 AM Alexander Aring wrote: > > > > > > I send this patch series as RFC because it was necessary to do a kref > > > change after

Re: [Cluster-devel] [RFC 0/2] refcount: attempt to avoid imbalance warnings

2022-07-01 Thread Alexander Aring
Hi, On Thu, Jun 30, 2022 at 12:34 PM Linus Torvalds wrote: > > On Thu, Jun 30, 2022 at 6:59 AM Alexander Aring wrote: > > > > I send this patch series as RFC because it was necessary to do a kref > > change after adding __cond_lock() to refcount_dec_and_lock() > > functionality. > > Can you try

Re: [Cluster-devel] [RFC 0/2] refcount: attempt to avoid imbalance warnings

2022-07-01 Thread Peter Zijlstra
On Thu, Jun 30, 2022 at 09:34:10AM -0700, Linus Torvalds wrote: Not commenting on sparse, since I'm not much qualified there, however, > include/linux/compiler_types.h | 2 ++ > include/linux/refcount.h | 6 +++--- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git

Re: [Cluster-devel] [RFC 0/2] refcount: attempt to avoid imbalance warnings

2022-06-30 Thread Linus Torvalds
On Thu, Jun 30, 2022 at 6:59 AM Alexander Aring wrote: > > I send this patch series as RFC because it was necessary to do a kref > change after adding __cond_lock() to refcount_dec_and_lock() > functionality. Can you try something like this instead? This is two separate patches - one for