Re: [Cluster-devel] [RFC v3 2/7] iomap: Add iomap_folio_done helper

2022-12-23 Thread Christoph Hellwig
On Fri, Dec 23, 2022 at 09:54:34PM +0100, Andreas Grünbacher wrote: > > But for the current version I don't really understand why the error > > unwinding changes here. > > Currently, we have this order of operations in iomap_write_begin(): > > folio_unlock() // folio_put() // iomap_write_failed

Re: [Cluster-devel] [RFC v3 2/7] iomap: Add iomap_folio_done helper

2022-12-23 Thread Andreas Grünbacher
Am Fr., 23. Dez. 2022 um 16:12 Uhr schrieb Christoph Hellwig : > On Fri, Dec 16, 2022 at 04:06:21PM +0100, Andreas Gruenbacher wrote: > > +static void iomap_folio_done(struct iomap_iter *iter, loff_t pos, size_t > > ret, > > + struct folio *folio) > > +{ > > + const struct iomap_pa

Re: [Cluster-devel] [RFC v3 2/7] iomap: Add iomap_folio_done helper

2022-12-23 Thread Christoph Hellwig
On Fri, Dec 16, 2022 at 04:06:21PM +0100, Andreas Gruenbacher wrote: > +static void iomap_folio_done(struct iomap_iter *iter, loff_t pos, size_t ret, > + struct folio *folio) > +{ > + const struct iomap_page_ops *page_ops = iter->iomap.page_ops; > + > + if (folio) > +