Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-14 Thread Valentin Vidic
On Mon, May 14, 2018 at 02:24:38PM +0100, Andrew Price wrote: > We can still keep this minimal if that's better for the Debian package. > > The issue is due to the log header checksum (lh_hash) being calculated using > sizeof(struct gfs2_log_header) and that size has increased in the latest >

Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-14 Thread Andrew Price
On 13/05/18 10:13, Valentin Vidic wrote: On Wed, May 09, 2018 at 05:53:19PM +0100, Andrew Price wrote: You should be able to fix this by using the configure.ac and gfs2/libgfs2/meta.c files from master. The diff should be very small. It'll need an ./autogen.sh to rebuild the configure script.

Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-13 Thread Valentin Vidic
On Wed, May 09, 2018 at 05:53:19PM +0100, Andrew Price wrote: > You should be able to fix this by using the configure.ac and > gfs2/libgfs2/meta.c files from master. The diff should be very small. It'll > need an ./autogen.sh to rebuild the configure script. > > The downside of that approach is

Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-10 Thread Valentin Vidic
On Wed, May 09, 2018 at 05:53:19PM +0100, Andrew Price wrote: > You should be able to fix this by using the configure.ac and > gfs2/libgfs2/meta.c files from master. The diff should be very small. It'll > need an ./autogen.sh to rebuild the configure script. > > The downside of that approach is

Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-04 Thread Valentin Vidic
On Fri, May 04, 2018 at 02:16:24PM +0100, Andrew Price wrote: > Try this. Thanks, only meta test fails now, probably size check in some other place: ## - ## ## Test results. ## ## - ## ERROR: All 30 tests were run, 1 failed unexpectedly. ## ##

Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-04 Thread Andrew Price
On 04/05/18 14:01, Andrew Price wrote: On 04/05/18 13:01, Valentin Vidic wrote: On Fri, May 04, 2018 at 12:07:01PM +0100, Andrew Price wrote: Hm curious. I *can* reproduce the same segfaults but only if I build with the 4.15 header and then rebuild with the 4.16 header *without* first running

Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-04 Thread Andrew Price
On 04/05/18 13:01, Valentin Vidic wrote: On Fri, May 04, 2018 at 12:07:01PM +0100, Andrew Price wrote: Hm curious. I *can* reproduce the same segfaults but only if I build with the 4.15 header and then rebuild with the 4.16 header *without* first running ./configure. If I run ./configure the

Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-04 Thread Valentin Vidic
On Fri, May 04, 2018 at 12:07:01PM +0100, Andrew Price wrote: > Hm curious. I *can* reproduce the same segfaults but only if I build with > the 4.15 header and then rebuild with the 4.16 header *without* first > running ./configure. If I run ./configure the problem resolves itself. Thanks, I

Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-04 Thread Andrew Price
On 04/05/18 11:54, Valentin Vidic wrote: On Fri, May 04, 2018 at 11:46:08AM +0100, Andrew Price wrote: Ok, so just to be clear, after installing the 4.16 gfs2_ondisk.h and then doing "./configure && make clean && make" the bug still occurs? Hm curious. I *can* reproduce the same segfaults but

Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-04 Thread Valentin Vidic
On Fri, May 04, 2018 at 11:46:08AM +0100, Andrew Price wrote: > Ok, so just to be clear, after installing the 4.16 gfs2_ondisk.h and then > doing "./configure && make clean && make" the bug still occurs? That is correct, attaching 4.16 gfs2_ondisk.h so you can test. -- Valentin /*

Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-04 Thread Andrew Price
On 04/05/18 11:42, Valentin Vidic wrote: On Fri, May 04, 2018 at 11:27:35AM +0100, Andrew Price wrote: One other thing to check is whether ./configure was re-run after gfs2_ondisk.h was upgraded. Yes, just restoring the previous version (4.15) of /usr/include/linux/gfs2_ondisk.h fixes

Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-04 Thread Valentin Vidic
On Fri, May 04, 2018 at 11:27:35AM +0100, Andrew Price wrote: > One other thing to check is whether ./configure was re-run after > gfs2_ondisk.h was upgraded. Yes, just restoring the previous version (4.15) of /usr/include/linux/gfs2_ondisk.h fixes the tests. -- Valentin

Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-04 Thread Andrew Price
On 04/05/18 11:21, Valentin Vidic wrote: On Fri, May 04, 2018 at 11:06:59AM +0100, Andrew Price wrote: Can you reproduce it with the master branch? Also, what is the size of your test file? And what architecture is this on? Master branch seems to fail too. Test file was 200 MB on amd64. Also

Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-04 Thread Andrew Price
Hi Valentin, On 04/05/18 10:50, Valentin Vidic wrote: On Fri, May 04, 2018 at 11:42:31AM +0200, Valentin Vidic wrote: We are starting to see mkfs segfaults after updating linux-libc-dev from 4.15.17-1 to 4.16.5-1 due to a change in gfs2_ondisk.h. Hope there is enough info below for a fix? :)

Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-04 Thread Valentin Vidic
On Fri, May 04, 2018 at 11:42:31AM +0200, Valentin Vidic wrote: > We are starting to see mkfs segfaults after updating > linux-libc-dev from 4.15.17-1 to 4.16.5-1 due to a > change in gfs2_ondisk.h. Hope there is enough info > below for a fix? :) Here goes another trace: (gdb) run -p