Re: [Cluster-devel] logsys in cluster3

2008-07-01 Thread David Teigland
On Tue, Jul 01, 2008 at 12:21:21PM -0500, David Teigland wrote: > (What doesn't work yet is the "test 1" output > following the logsys_init() call.) was missing logsys_flush() > +int logsys_init(char *name, int mode, int facility, int priority, char *file) > +{ > + char *errstr; Thinking ab

Re: [Cluster-devel] logsys in cluster3

2008-07-01 Thread David Teigland
Here's a patch that adds a simple, function-based api to logsys, allowing non-plugins to use it much more cleanly. It seems to mostly work with the attached test program, which illustrates how I expect to use it in various cluster3 programs. (What doesn't work yet is the "test 1" output following

Re: [Cluster-devel] logsys in cluster3

2008-07-01 Thread David Teigland
On Tue, Jul 01, 2008 at 07:01:42AM +0200, Fabio M. Di Nitto wrote: > No. You can just install the callback and be done with it. The ccs fd was > never a real fd to poll. OK, it's a cman callback. If the ccs "connection" isn't really a connection and if it's not necessary then can we get rid of t

Re: [Cluster-devel] logsys in cluster3

2008-06-30 Thread Fabio M. Di Nitto
On Mon, 30 Jun 2008, David Teigland wrote: On Mon, Jun 30, 2008 at 06:38:48PM +0200, Fabio M. Di Nitto wrote: On Mon, 30 Jun 2008, David Teigland wrote: - configuration setup: big blocks of setup code are repeated and largely the same, make this less I will take care of this bit since i alr

Re: [Cluster-devel] logsys in cluster3

2008-06-30 Thread David Teigland
On Mon, Jun 30, 2008 at 06:38:48PM +0200, Fabio M. Di Nitto wrote: > On Mon, 30 Jun 2008, David Teigland wrote: > > >- configuration setup: big blocks of setup code are repeated and largely > > the same, make this less > > I will take care of this bit since i already done it. > > the api will lo

Re: [Cluster-devel] logsys in cluster3

2008-06-30 Thread Fabio M. Di Nitto
On Mon, 30 Jun 2008, David Teigland wrote: - configuration setup: big blocks of setup code are repeated and largely the same, make this less I will take care of this bit since i already done it. the api will look like: int gimme_logging_config_data(char *name, int debug) return 0 if ok 1 o