Coverity showed that savemetaopen() can return a metafd without
initializing the gzfd member. This isn't currently a problem as we only
use gzfd when it is set but this patch initializes the metafd fully to
avoid future problems.
Signed-off-by: Andrew Price anpr...@redhat.com
---
The value of error is always 0 when this if statement is reached. This
patch removes it.
Signed-off-by: Andrew Price anpr...@redhat.com
---
gfs2/libgfs2/fs_ops.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/gfs2/libgfs2/fs_ops.c b/gfs2/libgfs2/fs_ops.c
index
This patch cleans up an error variable which was initialized to 0 and
then never changed, and a 'fail' section which could be replaced by a
return. It also removes the 'out' label which was only referenced from
the dead if-statement in the 'fail' section.
Signed-off-by: Andrew Price
When using 'find' on block types which require searching by resource
group, a segfault occurs in __gfs2_next_rg_meta due to rgd-bh being
empty. This patch fixes the segfault by reading in the resource group
data, thus populating rgd-bh, prior to the search.
Signed-off-by: Andrew Price
This patch removes an if statement where the true branch is never taken.
At this point in the code, poll_timeout could only be 500 or -1.
Signed-off-by: Andrew Price anpr...@redhat.com
---
group/gfs_controld/main.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git
Hi,
Those all look good to me,
Steve.
On Tue, 2011-09-06 at 13:00 +0100, Andrew Price wrote:
This patch removes an if statement where the true branch is never taken.
At this point in the code, poll_timeout could only be 500 or -1.
Signed-off-by: Andrew Price anpr...@redhat.com
---
On Tue, Sep 06, 2011 at 01:00:16PM +0100, Andrew Price wrote:
This patch removes an if statement where the true branch is never taken.
At this point in the code, poll_timeout could only be 500 or -1.
Signed-off-by: Andrew Price anpr...@redhat.com
---
group/gfs_controld/main.c |3 ---
Use rpmatch() function to get answer to
yes-or-no questions during mkfs confirmation
Signed-off-by: Carlos Maiolino cmaiol...@redhat.com
---
gfs2/mkfs/main_mkfs.c | 30 ++
1 files changed, 22 insertions(+), 8 deletions(-)
diff --git a/gfs2/mkfs/main_mkfs.c
Hi Carlos,
- Original Message -
| + do{
| + printf( _(\nAre you sure you want to proceed? [y/n]));
| + ret = getline(line, len, stdin);
| + res = rpmatch(line);
I'd like to see the free(line); moved right here after rpmatch.
Otherwise multiple iterations through the loop will leak
Resolves: rhbz#734730
Signed-off-by: Lon Hohberger l...@redhat.com
---
rgmanager/src/daemons/main.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/rgmanager/src/daemons/main.c b/rgmanager/src/daemons/main.c
index 4e12c68..931d95e 100644
---
10 matches
Mail list logo
