[Cluster-devel] [fsck.gfs2 patch] fsck.gfs2: Revise undo processing

2015-01-09 Thread Bob Peterson
Hi, This patch has to do with undo processing. This is where pass1 has processed a bunch of data blocks before encountering an error. If the error is fatal processing is stopped immediately and the work done to that point (up to the fatal error block) is backed out. If the error is not fatal,

Re: [Cluster-devel] [GFS2 PATCH] GFS2: Eliminate __gfs2_glock_remove_from_lru

2015-01-09 Thread Steven Whitehouse
Hi, Now in the -nmw tree. Thanks, Steve. On 05/01/15 18:25, Bob Peterson wrote: Hi, Since the only caller of function __gfs2_glock_remove_from_lru locks the same spin_lock as gfs2_glock_remove_from_lru, the functions can be combined. Regards, Bob Peterson Red Hat File Systems

[Cluster-devel] [fsck.gfs2 patch] fsck.gfs2: Change basic dentry checks for too long of file names

2015-01-09 Thread Bob Peterson
Hi, This is the first in a series of patches to fsck.gfs2. I've uncovered some problems during recent testing, and these patches fix them. This patch adds a check to the basic dentry check such that it will reject any dirents that have a file name more than the maximum allowed. Regards, Bob

[Cluster-devel] [fsck.gfs2 patch] fsck.gfs2: Print out block number when pass3 finds a bad directory

2015-01-09 Thread Bob Peterson
Hi, This patch changes pass3 so that it prints out the directory inode number when it finds a directory containing a bad block. Regards, Bob Peterson Red Hat File Systems Signed-off-by: Bob Peterson rpete...@redhat.com --- diff --git a/gfs2/fsck/pass3.c b/gfs2/fsck/pass3.c index

[Cluster-devel] [fsck.gfs2 patch] fsck.gfs2: Adjust when hash table is doubled

2015-01-09 Thread Bob Peterson
Hi, If directory entries are found to be on the wrong leaf block, they are moved as needed. That sometimes requires the leaf block to be split, which, in turn, sometimes requires the hash table be doubled. The problem was that the functions that traverse the hash tables were not taking into

[Cluster-devel] [fsck.gfs2 patch] fsck.gfs2: remove duplicate designation during undo

2015-01-09 Thread Bob Peterson
Hi, This patch fixes a problem whereby fsck.gfs2's pass1 would perform this sequence of events: 1. Metadata block X is identified as being referenced from dinode D1. 2. Metadata block X is identified as being referenced from another dinode, D2, which makes it a duplicate reference, but so far,