Re: [Cluster-devel] [PATCH v2] fs/dlm: Fix kernel memory disclosure

Hello, I wanted to ping the list and see if this could get a review: > Clear the 'unused' field and the uninitialized padding in 'lksb' to > avoid leaking memory to userland in copy_result_to_user(). > > Signed-off-by: Vlad Tsyrklevich > --- > fs/dlm/user.c | 2 ++ > 1

Re: [Cluster-devel] [PATCH v2] fs/dlm: Fix kernel memory disclosure

Hi, On 22/02/17 07:45, Vlad Tsyrklevich wrote: Hello, I wanted to ping the list and see if this could get a review: It looks good to me, Steve. Clear the 'unused' field and the uninitialized padding in 'lksb' to avoid leaking memory to userland in copy_result_to_user(). Signed-off-by:

Re: [Cluster-devel] [PATCH] gfs2: Add missing rcu locking for glock lookup

On Wed, Feb 22, 2017 at 4:13 PM, Steven Whitehouse wrote: > Hi, > > Looks good, but can we fix that "retry for 100 times" loop too at the same > time? There does appear to be an rhashtable API function that does what we > need there, The rhashtable cleanup which I've posted

Re: [Cluster-devel] [PATCH] gfs2: Add missing rcu locking for glock lookup

On Wed, Feb 22, 2017 at 4:26 PM, Andreas Gruenbacher wrote: > On Wed, Feb 22, 2017 at 4:13 PM, Steven Whitehouse > wrote: >> Hi, >> >> Looks good, but can we fix that "retry for 100 times" loop too at the same >> time? There does appear to be an

Re: [Cluster-devel] [PATCH v2] fs/dlm: Fix kernel memory disclosure

On Wed, Feb 22, 2017 at 03:45:34PM +0800, Vlad Tsyrklevich wrote: > Hello, I wanted to ping the list and see if this could get a review: now pushed to linux-dlm.git > > Clear the 'unused' field and the uninitialized padding in 'lksb' to > > avoid leaking memory to userland in

Re: [Cluster-devel] [PATCH] gfs2: Add missing rcu locking for glock lookup

- Original Message - | From: Andrew Price | | We must hold the rcu read lock across looking up glocks and trying to | bump their refcount to prevent the glocks from being freed in between. | | Signed-off-by: Andreas Gruenbacher | --- Hi,

[Cluster-devel] [PATCH 0/2] GFS2 rhashtable cleanup

The first of these patches adds rhashtable_lookup_get_insert_fast, which is modeled after rhashtable_lookup_get_insert_key and returns existing objects in the hash table, other than rhashtable_lookup_insert_fast which returns -EEXIST. The second of these patch cleans up the GFS2 gfs2 rhashtable

[Cluster-devel] [PATCH 1/2] rhashtable: Add rhashtable_lookup_get_insert_fast

Add rhashtable_lookup_get_insert_fast for fixed keys, similar to rhashtable_lookup_get_insert_key for explicit keys. Signed-off-by: Andreas Gruenbacher Cc: Pablo Neira Ayuso Cc: Herbert Xu Cc: Thomas Graf

Re: [Cluster-devel] [PATCH] gfs2: Add missing rcu locking for glock lookup

Hi, On 22/02/17 15:34, Andreas Gruenbacher wrote: On Wed, Feb 22, 2017 at 4:29 PM, Steven Whitehouse wrote: There should be no need to retry at all. Either the new entry will be added to the hash table, or it will find an existing entry in the table. Is there really some