[Cluster-devel] [PATCH 0/2] Fix xfstest generic/424

2017-10-09 Thread Andreas Gruenbacher
These two patches fix xfstest generic/424. Andreas Gruenbacher (2): gfs: Fix and clean up FS_IOC_{GET,SET}FLAGS gfs2: Add support for statx inode flags fs/gfs2/file.c | 102 ++-- fs/gfs2/inode.c | 14 2 files changed, 61

Re: [Cluster-devel] [PATCH] direct-io: Prevent NULL pointer access in submit_page_section

2017-10-09 Thread Andreas Gruenbacher
On 9 October 2017 at 18:22, Al Viro wrote: > On Mon, Oct 09, 2017 at 11:13:18AM +0200, Andreas Gruenbacher wrote: >> In the code added to function submit_page_section by commit b1058b981, >> sdio->bio can currently be NULL when calling dio_bio_submit. This then >> leads

[Cluster-devel] [PATCH 2/2] gfs2: Add support for statx inode flags

2017-10-09 Thread Andreas Gruenbacher
Add support for the STATX_ATTR_ flags in statx. (Compression, encryption, and the nodump flag are not supported by gfs2.) Partially fixes xfstest generic/424. Signed-off-by: Andreas Gruenbacher --- fs/gfs2/inode.c | 14 ++ 1 file changed, 14 insertions(+)

[Cluster-devel] [PATCH 1/2] gfs: Fix and clean up FS_IOC_{GET, SET}FLAGS

2017-10-09 Thread Andreas Gruenbacher
Switch to a simple array for mapping between the FS_*_FL and GFS_DIF_* flags. Clarify how the mapping between FS_JOURNAL_DATA_FL and the filesystem flags works. The GFS2_DIF_SYSTEM flag cannot be set from user space, so remove it from GFS2_FLAGS_USER_SET. Fail with -EINVAL when trying to set

Re: [Cluster-devel] [PATCH] direct-io: Prevent NULL pointer access in submit_page_section

2017-10-09 Thread Al Viro
On Mon, Oct 09, 2017 at 11:13:18AM +0200, Andreas Gruenbacher wrote: > In the code added to function submit_page_section by commit b1058b981, > sdio->bio can currently be NULL when calling dio_bio_submit. This then > leads to a NULL pointer access in dio_bio_submit, so check for a NULL > bio in

[Cluster-devel] [PATCH 08/16] gfs2: Use pagevec_lookup_range_tag()

2017-10-09 Thread Jan Kara
We want only pages from given range in gfs2_write_cache_jdata(). Use pagevec_lookup_range_tag() instead of pagevec_lookup_tag() and remove unnecessary code. CC: Bob Peterson CC: cluster-devel@redhat.com Reviewed-by: Daniel Jordan Signed-off-by:

Re: [Cluster-devel] [BUG] fs/dlm: A possible sleep-in-atomic bug in dlm_master_lookup

2017-10-09 Thread David Teigland
On Sat, Oct 07, 2017 at 03:26:11AM +0100, Al Viro wrote: > On Sat, Oct 07, 2017 at 09:59:41AM +0800, Jia-Ju Bai wrote: > > According to fs/dlm/lock.c, the kernel may sleep under a spinlock, > > and the function call path is: > > dlm_master_lookup (acquire the spinlock) > >

[Cluster-devel] (no subject)

2017-10-09 Thread Andreas Gruenbacher
Date: Wed, 4 Oct 2017 23:09:38 +0200 Subject: [PATCH] direct-io: Prevent NULL pointer access in submit_page_section In the code added to function submit_page_section by commit b1058b981, sdio->bio can currently be NULL when calling dio_bio_submit. This then leads to a NULL pointer access in

[Cluster-devel] [PATCH] direct-io: Prevent NULL pointer access in submit_page_section

2017-10-09 Thread Andreas Gruenbacher
In the code added to function submit_page_section by commit b1058b981, sdio->bio can currently be NULL when calling dio_bio_submit. This then leads to a NULL pointer access in dio_bio_submit, so check for a NULL bio in submit_page_section before trying to submit it instead. Fixes xfstest

[Cluster-devel] [BUG] fs/dlm: A possible sleep-in-atomic bug in dlm_master_lookup

2017-10-09 Thread Jia-Ju Bai
According to fs/dlm/lock.c, the kernel may sleep under a spinlock, and the function call path is: dlm_master_lookup (acquire the spinlock) dlm_send_rcom_lookup_dump create_rcom dlm_lowcomms_get_buffer nodeid2con mutex_lock --> may sleep This bug is found by my