Re: [Cluster-devel] [PATCH 1/2] GFS2: use schedule timeout in find insert glock

2018-10-09 Thread Mark Syms
Having swapped the line below around we still see the timeout on schedule fire, but only once in a fairly mega stress test. This is why we weren't worried about the timeout being HZ, the situation is hardly ever hit as having to wait is rare and normally we are woken from schedule and without a

Re: [Cluster-devel] [PATCH 1/2] GFS2: use schedule timeout in find insert glock

2018-10-09 Thread Steven Whitehouse
On 09/10/18 09:13, Mark Syms wrote: Having swapped the line below around we still see the timeout on schedule fire, but only once in a fairly mega stress test. This is why we weren't worried about the timeout being HZ, the situation is hardly ever hit as having to wait is rare and normally w

Re: [Cluster-devel] [PATCH 1/2] GFS2: use schedule timeout in find insert glock

2018-10-09 Thread Mark Syms
We think we have, just making a build to test. Will follow up later. Mark. -Original Message- From: Steven Whitehouse Sent: 09 October 2018 09:41 To: Mark Syms ; Tim Smith Cc: cluster-devel@redhat.com; Ross Lagerwall Subject: Re: [Cluster-devel] [PATCH 1/2] GFS2: use schedule timeout

Re: [Cluster-devel] [PATCH 1/2] GFS2: use schedule timeout in find insert glock

2018-10-09 Thread Andreas Gruenbacher
On Mon, 8 Oct 2018 at 15:27, Tim Smith wrote: > > On Monday, 8 October 2018 14:13:10 BST Steven Whitehouse wrote: > > Hi, > > > > On 08/10/18 14:10, Tim Smith wrote: > > > On Monday, 8 October 2018 14:03:24 BST Steven Whitehouse wrote: > > >> On 08/10/18 13:59, Mark Syms wrote: > > >>> That sounds

Re: [Cluster-devel] [PATCH 1/2] GFS2: use schedule timeout in find insert glock

2018-10-09 Thread Tim Smith
On Tuesday, 9 October 2018 13:34:47 BST you wrote: > On Mon, 8 Oct 2018 at 15:27, Tim Smith wrote: > > On Monday, 8 October 2018 14:13:10 BST Steven Whitehouse wrote: > > > Hi, > > > > > > On 08/10/18 14:10, Tim Smith wrote: > > > > On Monday, 8 October 2018 14:03:24 BST Steven Whitehouse wrote:

Re: [Cluster-devel] [PATCH 1/2] GFS2: use schedule timeout in find insert glock

2018-10-09 Thread Andreas Gruenbacher
Mark and Tim, does the following patch fix the problem, perhaps? Thanks, Andreas --- fs/gfs2/glock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index 4614ee25f621..71e7c380d4c4 100644 --- a/fs/gfs2/glock.c +++ b/fs/gfs2/glock.c @@ -121,

Re: [Cluster-devel] [PATCH 1/2] GFS2: use schedule timeout in find insert glock

2018-10-09 Thread Tim Smith
On Tuesday, 9 October 2018 14:00:34 BST Andreas Gruenbacher wrote: > On Tue, 9 Oct 2018 at 14:46, Tim Smith wrote: > > On Tuesday, 9 October 2018 13:34:47 BST you wrote: > > > On Mon, 8 Oct 2018 at 15:27, Tim Smith wrote: > > > > On Monday, 8 October 2018 14:13:10 BST Steven Whitehouse wrote: > >

Re: [Cluster-devel] [PATCH 1/2] GFS2: use schedule timeout in find insert glock

2018-10-09 Thread Tim Smith
On Tuesday, 9 October 2018 15:47:21 BST Andreas Gruenbacher wrote: > Mark and Tim, > > does the following patch fix the problem, perhaps? The assertion being that there are several waiters. Certainly possible. We'll give it a try. It takes ~12 hours to hit one instance of this so we've got plen

[Cluster-devel] [PATCH] gfs2: Fix iomap buffered write support for journaled files

2018-10-09 Thread Andreas Gruenbacher
Commit 64bc06bb32ee broke buffered writes to journaled files (chattr +j): we'll try to journal the buffer heads of the page being written to in gfs2_iomap_journaled_page_done. However, the iomap code no longer creates buffer heads, so we'll BUG() in gfs2_page_add_databufs. Fix that by creating bu

[Cluster-devel] [GIT PULL] gfs2: 4.19 fix

2018-10-09 Thread Andreas Gruenbacher
Hi Greg, could you please pull the following gfs2 fix for 4.19? This fixes a regression introduced in commit 64bc06bb32ee "gfs2: iomap buffered write support" (4.19-rc1). Thanks, Andreas -- The following changes since commit 0854ba5ff5c938307cd783e996b62c83f1ce923b: Merge git://git.kernel.or