Re: [Cluster-devel] [PATCH 1/2] gfs2: Fix occasional glock use-after-free

2019-03-26 Thread Bob Peterson
Hi Ross, - Original Message - > 6. gfs2_log_flush() continues and calls revoke_lo_after_commit() and > uses the freed glock (stack trace above). > > Should evict_inode call gfs2_ail_flush() or something so that the revoke > is written before it drops its reference to the glock? > > Or

Re: [Cluster-devel] [PATCH 1/2] gfs2: Fix occasional glock use-after-free

2019-03-26 Thread Ross Lagerwall
On 1/31/19 5:18 PM, Andreas Gruenbacher wrote: Hi Ross, On Thu, 31 Jan 2019 at 11:56, Ross Lagerwall wrote: Each gfs2_bufdata stores a reference to a glock but the reference count isn't incremented. This causes an occasional use-after-free of the glock. Fix by taking a reference on the glock

Re: [Cluster-devel] GFS2 filesystem corruption when mkfs block size (4k) does not match blockdevice blocksize (512 bytes)

2019-03-26 Thread Andreas Gruenbacher
Hi Edwin, On Mon, 25 Mar 2019 at 20:07, Edwin Török wrote: > On 20/03/2019 15:54, Edwin Török wrote: > > Hello, > > > > The patch below to xfstests reliably reproduces the filesystem corruption > > on a 4.19 kernel. > > I've also reproduced this on CentOS 7.6: > [ 2565.093062] Buffer I/O error