Re: [Cluster-devel] [PATCH 08/27] btrfs: use bdev_max_active_zones instead of open coding it

2022-04-19 Thread Anand Jain
On 4/15/22 12:52, Christoph Hellwig wrote: Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn Acked-by: David Sterba LGTM. Reviewed-by: Anand Jain --- fs/btrfs/zoned.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zone

Re: [Cluster-devel] [PATCH 27/27] direct-io: remove random prefetches

2022-04-19 Thread David Sterba
On Fri, Apr 15, 2022 at 06:52:58AM +0200, Christoph Hellwig wrote: > Randomly poking into block device internals for manual prefetches isn't > exactly a very maintainable thing to do. And none of the performance > criticil direct I/O implementations still use this library function > anyway, so jus

Re: [Cluster-devel] [PATCH RESEND] gfs2: Return more useful errors from gfs2_rgrp_send_discards()

2022-04-19 Thread Andrew Price
On 05/04/2022 13:08, Andrew Price wrote: The bug that 27ca8273f ("gfs2: Make sure FITRIM minlen is rounded up to fs block size") fixes was a little confusing as the user saw "Input/output error" which masked the -EINVAL that sb_issue_discard() returned. sb_issue_discard() can fail for various re