Re: [Cluster-devel] [PATCH 1/3] GFS2: Rework reclaiming unlinked dinodes

2010-05-25 Thread Christoph Hellwig
On Tue, May 25, 2010 at 09:21:27AM +0100, Steven Whitehouse wrote: > From: Bob Peterson > > The previous patch I wrote for reclaiming unlinked dinodes > had some shortcomings and did not prevent all hangs. > This version is much cleaner and more logical, and has > passed very difficult testing.

[Cluster-devel] GFS2: Pull request (fixes)

2010-05-25 Thread Steven Whitehouse
Hi, Please consider pulling the following three GFS2 fixes, Steve. --- The following changes since commit d7dbf4ffee1c7a17e2e5b5f01efe76fbd1671db6: Linus Torvalds (1): Merge branch 'for-linus' of git://git.kern

[Cluster-devel] [PATCH 1/3] GFS2: Rework reclaiming unlinked dinodes

2010-05-25 Thread Steven Whitehouse
From: Bob Peterson The previous patch I wrote for reclaiming unlinked dinodes had some shortcomings and did not prevent all hangs. This version is much cleaner and more logical, and has passed very difficult testing. Sorry for the churn. Signed-off-by: Bob Peterson Signed-off-by: Steven Whiteh

[Cluster-devel] [PATCH 3/3] GFS2: Fix permissions checking for setflags ioctl()

2010-05-25 Thread Steven Whitehouse
We should be checking for the ownership of the file for which flags are being set, rather than just for write access. Reported-by: Dan Rosenberg Signed-off-by: Steven Whitehouse --- fs/gfs2/file.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/fs/gfs2/file.c b/fs

[Cluster-devel] [PATCH 2/3] GFS2: Don't "get" xattrs for ACLs when ACLs are turned off

2010-05-25 Thread Steven Whitehouse
This is to match ext3 behaviour. We should not allow getting of xattrs relating to ACLs when ACLs are turned off. Reported-by: Nate Straz Signed-off-by: Steven Whitehouse --- fs/gfs2/acl.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/fs/gfs2/acl.c b/fs/gfs2/acl.c

[Cluster-devel] GFS2: Pre-pull patch posting (fixes)

2010-05-25 Thread Steven Whitehouse
Hi, These are three important, but relatively small, bug fixes for GFS2. The first prevents a kernel BUG triggering in a relatively unlikely (but possible) scenario when a log flush caused by glock demotion races with a log flush from some other initiator (e.g. fsync). The second and third patche