Re: [Cluster-devel] [PATCH] dlm: send_bast_queue() skip list loop not only sending basts to convertqueue

2011-01-04 Thread David Teigland
On Tue, Jan 04, 2011 at 06:06:51PM -0200, cmaiol...@redhat.com wrote: > The resource groups got corrupted without this patch: I could see an extraneous bast leading to confusion in gfs2 about the lock state, but gfs2 should probably be asserting somewhere before it actually corrupts anything... >

Re: [Cluster-devel] [PATCH] cman: Fix udpb handling in cman-preconfig

2011-01-04 Thread Lon Hohberger
On Tue, 2011-01-04 at 10:00 +0100, Jan Friesse wrote: > Lon, > even it may "logically" seemed that original code is incorrect and your > patch make sense, it's not the case. > > Actually, corosync has 3 transports: > udp, udpu and iba. > > Broadcast is same transport as udp but only has broadcast

[Cluster-devel] [PATCH] dlm: send_bast_queue() skip list loop not only sending basts to convertqueue

2011-01-04 Thread cmaiolino
From: Carlos Maiolino with the current check condition: if (gr == lkb), the list will skip not only basts sent to convertqueue since gr == lkb could be true on another situations, where such can cause a gfs2 corruption. Corruption checked on gfs2 resource groups, adding a file on a node and r

Re: [Cluster-devel] [PATCH] cman: Fix udpb handling in cman-preconfig

2011-01-04 Thread Jan Friesse
Fabio M. Di Nitto wrote: > On 1/4/2011 10:00 AM, Jan Friesse wrote: >> Lon, >> even it may "logically" seemed that original code is incorrect and your >> patch make sense, it's not the case. >> >> Actually, corosync has 3 transports: >> udp, udpu and iba. >> >> Broadcast is same transport as udp b

Re: [Cluster-devel] [PATCH] cman: Fix udpb handling in cman-preconfig

2011-01-04 Thread Fabio M. Di Nitto
On 1/4/2011 10:00 AM, Jan Friesse wrote: > Lon, > even it may "logically" seemed that original code is incorrect and your > patch make sense, it's not the case. > > Actually, corosync has 3 transports: > udp, udpu and iba. > > Broadcast is same transport as udp but only has broadcast flag set on.

Re: [Cluster-devel] [PATCH] cman: Fix udpb handling in cman-preconfig

2011-01-04 Thread Jan Friesse
Lon, even it may "logically" seemed that original code is incorrect and your patch make sense, it's not the case. Actually, corosync has 3 transports: udp, udpu and iba. Broadcast is same transport as udp but only has broadcast flag set on. In other words, this patch is not correct. Regards,