Re: [Cluster-devel] Changes to fencing.py

2011-03-22 Thread Lon Hohberger
On Tue, Mar 22, 2011 at 11:14:07AM +1100, Matt Clark wrote: > > Hi, > I sent an email a little while about a fencing agent script I was writing to > handle Citrix XenServer virtual machine (and apparently XCP virtual machine). > I think I am pretty close to finishing this off as I haven't made a

[Cluster-devel] [GFS2 PATCH] gfs2: move function foreach_leaf to gfs2_dir_exhash_dealloc

2011-03-22 Thread Bob Peterson
Hi, gfs2: move function foreach_leaf to gfs2_dir_exhash_dealloc The previous patches made function gfs2_dir_exhash_dealloc do nothing but call function foreach_leaf. This patch simplifies the code by moving the entire function foreach_leaf into gfs2_dir_exhash_dealloc. Regards, Bob Peterson Re

[Cluster-devel] [GFS2 PATCH] gfs2: pass leaf_bh into leaf_dealloc

2011-03-22 Thread Bob Peterson
Hi, Function foreach_leaf used to look up the leaf block address and get a buffer_head. Then it would call leaf_dealloc which did the same lookup. This patch combines the two operations by making foreach_leaf pass the leaf bh to leaf_dealloc. Regards, Bob Peterson Red Hat File Systems Signed-

[Cluster-devel] [GFS2 PATCH] gfs2: Combine transaction from gfs2_dir_exhash_dealloc

2011-03-22 Thread Bob Peterson
Hi, At the end of function gfs2_dir_exhash_dealloc, it was setting the dinode type to "file" to prevent directory corruption in case of a crash. It was doing so in its own journal transaction. This patch makes the change occur when the last call is make to leaf_dealloc, since it needs to rewrite

[Cluster-devel] [GFS2 PATCH] gfs2: remove *leaf_call_t and simplify leaf_dealloc

2011-03-22 Thread Bob Peterson
Hi, Since foreach_leaf is only called with leaf_dealloc as its only possible call function, we can simplify the code by making it call leaf_dealloc directly. This simplifies the code and eliminates the need for leaf_call_t, the generic call method. This is a first small step in simplifying the d

[Cluster-devel] [GFS2 PATCH] Dump better debug info if a bitmap inconsistency is detected

2011-03-22 Thread Bob Peterson
Hi, On rare occasions we encounter gfs2 problems where an invalid bitmap state transition is attempted. For example, trying to "unlink" a free block. In these cases, there is really no useful information logged to debug the problem. This patch adds more debug details that should allow us to more

Re: [Cluster-devel] [PATCH] cman: Don't increment on LEAVING->MEMBER transition

2011-03-22 Thread Christine Caulfield
On 22/03/11 08:33, Fabio M. Di Nitto wrote: The patch looks sane to me and I am fairly sure it needs to be applied to STABLE31/RHEL6 too. I´d like also an ACK from Chrissie here. ACK Chrissie Fabio On 3/22/2011 2:06 AM, Lon Hohberger wrote: If a node left the cluster prior using 'cman_too

Re: [Cluster-devel] [PATCH] resource-agents: Try force-unmount before fuser for netfs.sh

2011-03-22 Thread Fabio M. Di Nitto
ACK. Fabio On 3/22/2011 2:07 AM, Lon Hohberger wrote: > RHEL5 only. A completely separate patch is needed for > upstream and RHEL6 > > Resolves: rhbz#678494 > > Signed-off-by: Lon Hohberger > --- > rgmanager/src/resources/netfs.sh |7 ++- > 1 files changed, 6 insertions(+), 1 deletio

Re: [Cluster-devel] [PATCH] cman: Don't increment on LEAVING->MEMBER transition

2011-03-22 Thread Fabio M. Di Nitto
The patch looks sane to me and I am fairly sure it needs to be applied to STABLE31/RHEL6 too. I´d like also an ACK from Chrissie here. Fabio On 3/22/2011 2:06 AM, Lon Hohberger wrote: > If a node left the cluster prior using 'cman_tool leave', its > internal state is set to NODESTATE_LEAVING. >