[Cluster-devel] commit emails are back

2012-01-05 Thread Fabio M. Di Nitto
Hi all, after an upgrade on fedorahosted, our git2email gateway broke. The gateway is working again as of this morning. Please let me know if you notice any issue. Fabio

Re: [Cluster-devel] [GFS2 Patch] GFS2: fsck.gfs2 finds unlinked inodes on full file systems

2012-01-05 Thread Steven Whitehouse
Hi, This doesn't compile CC [M] fs/gfs2/inode.o fs/gfs2/inode.c: In function ‘gfs2_create_inode’: fs/gfs2/inode.c:741:2: error: implicit declaration of function ‘gfs2_dinode_dealloc’ make[2]: *** [fs/gfs2/inode.o] Error 1 make[1]: *** [fs/gfs2] Error 2 make: *** [fs] Error 2 Steve. On

[Cluster-devel] GFS2: Pre-pull patch posting (merge window)

2012-01-05 Thread Steven Whitehouse
Hi, The main feature this time is clean up around the allocation and resource group code. Otherwise the remainder is mostly small bug fixes. I've held back the glock stats patch and that will probably be ready for the following merge window with a bit of luck, Steve.

[Cluster-devel] [PATCH 03/16] GFS2: More automated code analysis fixes

2012-01-05 Thread Steven Whitehouse
A potentially uninitialised variable, some unreachable code, and the main part of this, fixing the error path in the unlink function. Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c index 41d494d..f6be14f 100644 --- a/fs/gfs2/bmap.c +++

[Cluster-devel] [PATCH 02/16] GFS2: Add readahead to sequential directory traversal

2012-01-05 Thread Steven Whitehouse
From: Bob Peterson rpete...@redhat.com This patch adds read-ahead capability to GFS2's directory hash table management. It greatly improves performance for some directory operations. For example: In one of my file systems that has 1000 directories, each of which has 1000 files, time to execute

[Cluster-devel] [PATCH 01/16] GFS2: Fix up REQ flags

2012-01-05 Thread Steven Whitehouse
Christoph has split up REQ_PRIO from REQ_META. That means that we can drop REQ_PRIO from places where is it not needed. I'm not at all sure that the combination WRITE_FLUSH_FUA | REQ_PRIO makes any kind of sense, anyway. In addition, I've added REQ_META to one place in the code where it was

[Cluster-devel] [PATCH 09/16] GFS2: O_(D)SYNC support for fallocate

2012-01-05 Thread Steven Whitehouse
Add sync of metadata after fallocate for O_SYNC files to ensure that we meet expectations for everything being on disk in this case. Unfortunately, the offset and len parameters are modified during the course of the fallocate function, so I've had to add a couple of new variables to call

[Cluster-devel] [PATCH 11/16] GFS2: Fix up off by one in the previous patch

2012-01-05 Thread Steven Whitehouse
The trace point should take extlen and not *ndata as the extent length. Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index b8935af..f1d1960 100644 --- a/fs/gfs2/rgrp.c +++ b/fs/gfs2/rgrp.c @@ -1378,7 +1378,7 @@ int gfs2_alloc_blocks(struct

[Cluster-devel] [PATCH 05/16] GFS2: f_ra is always valid in dir readahead function

2012-01-05 Thread Steven Whitehouse
As a result, we don't need to test it each time. Signed-off-by: Steven Whitehouse swhit...@redhat.com Cc: Bob Peterson rpete...@redhat.com diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c index 9144117..946b6f8 100644 --- a/fs/gfs2/dir.c +++ b/fs/gfs2/dir.c @@ -1378,12 +1378,14 @@ out: return

[Cluster-devel] [PATCH 10/16] GFS2: move toward a generic multi-block allocator

2012-01-05 Thread Steven Whitehouse
From: Bob Peterson rpete...@redhat.com This patch is a revision of the one I previously posted. I tried to integrate all the suggestions Steve gave. The purpose of the patch is to change function gfs2_alloc_block (allocate either a dinode block or an extent of data blocks) to a more generic

[Cluster-devel] [PATCH 12/16] GFS2: split function rgblk_search

2012-01-05 Thread Steven Whitehouse
From: Bob Peterson rpete...@redhat.com This patch splits function rgblk_search into a function that finds blocks to allocate (rgblk_search) and a function that assigns those blocks (gfs2_alloc_extent). Signed-off-by: Bob Peterson rpete...@redhat.com Signed-off-by: Steven Whitehouse

[Cluster-devel] [PATCH 15/16] GFS2: We only need one ACL getting function

2012-01-05 Thread Steven Whitehouse
There is no need to have two versions of this function with slightly different arguments. Signed-off-by: Steven Whitehouse swhit...@redhat.com diff --git a/fs/gfs2/acl.c b/fs/gfs2/acl.c index 65978d7..230eb0f 100644 --- a/fs/gfs2/acl.c +++ b/fs/gfs2/acl.c @@ -38,8 +38,9 @@ static const char

[Cluster-devel] [PATCH 07/16] GFS2: combine gfs2_alloc_block and gfs2_alloc_di

2012-01-05 Thread Steven Whitehouse
From: Bob Peterson rpete...@redhat.com GFS2 functions gfs2_alloc_block and gfs2_alloc_di do basically the same things, with a few exceptions. This patch combines the two functions into a slightly more generic gfs2_alloc_block. Having one centralized block allocation function will reduce code

[Cluster-devel] [PATCH 14/16] GFS2: Fix multi-block allocation

2012-01-05 Thread Steven Whitehouse
Clean up gfs2_alloc_blocks so that it takes the full extent length rather than just the number of non-inode blocks as an argument. That will only make a difference in the inode allocation case for now. Also, this fixes the extent length handling around gfs2_alloc_extent() so that multi block

[Cluster-devel] [PATCH 16/16] GFS2: local functions should be static

2012-01-05 Thread Steven Whitehouse
From: H Hartley Sweeten hartl...@visionengravers.com Quiets the sparse noise: warning: symbol 'gfs2_initxattrs' was not declared. Should it be static? Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Steven Whitehouse swhit...@redhat.com Signed-off-by: Steven Whitehouse

Re: [Cluster-devel] [GFS2 Patch] GFS2: fsck.gfs2 finds unlinked inodes on full file systems

2012-01-05 Thread Bob Peterson
- Original Message - | Hi, | | This doesn't compile | | CC [M] fs/gfs2/inode.o | fs/gfs2/inode.c: In function ‘gfs2_create_inode’: | fs/gfs2/inode.c:741:2: error: implicit declaration of function | ‘gfs2_dinode_dealloc’ | make[2]: *** [fs/gfs2/inode.o] Error 1 | make[1]: ***

Re: [Cluster-devel] [PATCH 5/5] gfs2: dlm based recovery coordination

2012-01-05 Thread Bob Peterson
- Original Message - | This new method of managing recovery is an alternative to | the previous approach of using the userland gfs_controld. | | - use dlm slot numbers to assign journal id's | - use dlm recovery callbacks to initiate journal recovery | - use a dlm lock to determine the

Re: [Cluster-devel] [PATCH 5/5] gfs2: dlm based recovery coordination

2012-01-05 Thread David Teigland
On Thu, Jan 05, 2012 at 10:08:15AM -0500, Bob Peterson wrote: - Original Message - | This new method of managing recovery is an alternative to | the previous approach of using the userland gfs_controld. | | - use dlm slot numbers to assign journal id's | - use dlm recovery callbacks

Re: [Cluster-devel] [GFS2 Patch] GFS2: fsck.gfs2 finds unlinked inodes on full file systems

2012-01-05 Thread Steven Whitehouse
Hi, On Thu, 2012-01-05 at 09:57 -0500, Bob Peterson wrote: - Original Message - | Hi, | | This doesn't compile | | CC [M] fs/gfs2/inode.o | fs/gfs2/inode.c: In function ‘gfs2_create_inode’: | fs/gfs2/inode.c:741:2: error: implicit declaration of function |

Re: [Cluster-devel] [PATCH 5/5] gfs2: dlm based recovery coordination

2012-01-05 Thread Steven Whitehouse
Hi, On Thu, 2012-01-05 at 10:21 -0500, David Teigland wrote: On Thu, Jan 05, 2012 at 10:08:15AM -0500, Bob Peterson wrote: - Original Message - | This new method of managing recovery is an alternative to | the previous approach of using the userland gfs_controld. | | - use dlm

[Cluster-devel] [PATCH 1/5] rgmanager: Add extra service status call (RHEL5)

2012-01-05 Thread Lon Hohberger
Pass the flags and last transition time back to caller if the caller requests it with an additional parameter. Resolves: rhbz#743214 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/src/daemons/slang_event.c | 105 +-- 1 files changed, 100

[Cluster-devel] [PATCH 5/5] rgmanager: Fix dependency issue related to ordering (RHEL5)

2012-01-05 Thread Lon Hohberger
If you ordered two services the opposite way in cluster.conf ('b' first, which depends on 'a'), then rgmanager would fail over 'b' despite the fact that 'a' was not running yet - this is because the state of 'a' was not set to 'stopped' - so we need to check for a node-death event in

[Cluster-devel] [PATCH 4/5] rgmanager: Fix tiny memory leak in sl_service_status (RHEL5)

2012-01-05 Thread Lon Hohberger
Resolves: rhbz#743214 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/src/daemons/slang_event.c | 23 ++- 1 files changed, 14 insertions(+), 9 deletions(-) diff --git a/rgmanager/src/daemons/slang_event.c b/rgmanager/src/daemons/slang_event.c index

[Cluster-devel] [PATCH 3/5] rgmanager: Fix call to service_status() (RHEL5)

2012-01-05 Thread Lon Hohberger
This patch simply fixes the calls to service_status(), the s_trans variable was being incorrectly set. Resolves: rhbz#743214 Signed-off-by: Lon Hohberger l...@redhat.com --- rgmanager/src/resources/default_event_script.sl |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff

[Cluster-devel] [PATCH 2/5] rgmanager: Avoid duplicate restart of service (RHEL5)

2012-01-05 Thread Lon Hohberger
If B depends on A and both A and B are running on node 1 and node 1 fails, the stop events generated will inadvertently cause B to be restarted after the initial failover. This patch resolves this issue by comparing the start times in central_processing mode. A known limitation to this patch is

Re: [Cluster-devel] [PATCH 5/5] rgmanager: Fix dependency issue related to ordering (RHEL5)

2012-01-05 Thread Lon Hohberger
On 01/05/2012 10:57 AM, Lon Hohberger wrote: @@ -521,8 +523,8 @@ define default_service_event_handler() (s_trans,, s_state) = service_status(service_name, 1); if ((s_state == started) and (state == started) and

[Cluster-devel] [PATCH] fence_vmware_soap: Support for 100+ VM in VMWare

2012-01-05 Thread Marek 'marx' Grac
In previous version, we did not try to get all results for VM. This updated version fixes this issue by using proper SOAP API Resolves: rhbz#735797 --- fence/agents/vmware_soap/fence_vmware_soap.py | 34 + 1 files changed, 23 insertions(+), 11 deletions(-) diff --git

Re: [Cluster-devel] [PATCH 5/5] gfs2: dlm based recovery coordination

2012-01-05 Thread Bob Peterson
- Original Message - | This new method of managing recovery is an alternative to | the previous approach of using the userland gfs_controld. | | - use dlm slot numbers to assign journal id's | - use dlm recovery callbacks to initiate journal recovery | - use a dlm lock to determine the

[Cluster-devel] [PATCH 1/5] dlm: convert rsb list to rb_tree

2012-01-05 Thread David Teigland
From: Bob Peterson rpete...@redhat.com Change the linked lists to rb_tree's in the rsb hash table to speed up searches. Slow rsb searches were having a large impact on gfs2 performance due to the large number of dlm locks gfs2 uses. Signed-off-by: Bob Peterson rpete...@redhat.com Signed-off-by:

[Cluster-devel] [PATCH 0/5] dlm and gfs2 patches for 3.3

2012-01-05 Thread David Teigland
These are dlm and gfs2 patches from -next proposed for 3.3. The gfs2 part still needs an ack from Steve W, so it could be dropped. The patches add a major feature to the dlm and gfs2 that allows gfs2 mounters and recovery to be managed directly within the kernel, via the dlm, rather than in

[Cluster-devel] [PATCH 3/5] dlm: add node slots and generation

2012-01-05 Thread David Teigland
Slot numbers are assigned to nodes when they join the lockspace. The slot number chosen is the minimum unused value starting at 1. Once a node is assigned a slot, that slot number will not change while the node remains a lockspace member. If the node leaves and rejoins it can be assigned a new

[Cluster-devel] [PATCH 2/5] dlm: move recovery barrier calls

2012-01-05 Thread David Teigland
Put all the calls to recovery barriers in the same function to clarify where they each happen. Should not change any behavior. Also modify some recovery debug lines to make them consistent. Signed-off-by: David Teigland teigl...@redhat.com --- fs/dlm/dir.c |1 - fs/dlm/member.c |

[Cluster-devel] [PATCH 5/5] gfs2: dlm based recovery coordination

2012-01-05 Thread David Teigland
This new method of managing recovery is an alternative to the previous approach of using the userland gfs_controld. - use dlm slot numbers to assign journal id's - use dlm recovery callbacks to initiate journal recovery - use a dlm lock to determine the first node to mount fs - use a dlm lock to

[Cluster-devel] [PATCH 4/5] dlm: add recovery callbacks

2012-01-05 Thread David Teigland
These new callbacks notify the dlm user about lock recovery. GFS2, and possibly others, need to be aware of when the dlm will be doing lock recovery for a failed lockspace member. In the past, this coordination has been done between dlm and file system daemons in userspace, which then direct

Re: [Cluster-devel] [PATCH 5/5] gfs2: dlm based recovery coordination

2012-01-05 Thread David Teigland
On Thu, Jan 05, 2012 at 04:58:22PM +, Steven Whitehouse wrote: + clear_bit(SDF_NOJOURNALID, sdp-sd_flags); + smp_mb__after_clear_bit(); + wake_up_bit(sdp-sd_flags, SDF_NOJOURNALID); + ls-ls_first = !!test_bit(DFL_FIRST_MOUNT, ls-ls_recover_flags); + return 0; + This

Re: [Cluster-devel] [PATCH 5/6] net: add paged frag destructor support to kernel_sendpage.

2012-01-05 Thread David Miller
From: Ian Campbell ian.campb...@citrix.com Date: Thu, 5 Jan 2012 17:13:43 + -static ssize_t do_tcp_sendpages(struct sock *sk, struct page **pages, int poffset, +static ssize_t do_tcp_sendpages(struct sock *sk, + struct page **pages, +

Re: [Cluster-devel] [GFS2 Patch] GFS2: fsck.gfs2 finds unlinked inodes on full file systems

2012-01-05 Thread Bob Peterson
- Original Message - | One further thought... since the struct inode exists by the stage we | hit | those error cases, it should be deallocated when it gets iput() in | the | error case. So I wonder why thats not happened... perhaps i_nlink is | not | zero at that time? | | Steve. Hi,