Re: [Cluster-devel] [GFS2 PATCH] GFS2: put glock reference in error patch of read_rindex_entry

2012-03-23 Thread Steven Whitehouse
Hi, On Thu, 2012-03-22 at 08:58 -0400, Bob Peterson wrote: Hi, This patch fixes the error path of function read_rindex_entry so that it correctly gives up its glock reference in cases where there is a race to re-read the rindex after gfs2_grow. Regards, I'll add this to the -fixes tree

[Cluster-devel] GPF in dlm_lowcomms_stop

2012-03-23 Thread dann frazier
I observed a GPF in dlm_lowcomms_stop() in a crash dump from a user. I'll include a traceback at the bottom. I have a theory as to what is going on, but could use some help proving it. 1 void dlm_lowcomms_stop(void) 2 { 3 /* Set all the flags to prevent any 4 socket activity. 5 */ 6

Re: [Cluster-devel] GFS2: Pre-pull patch posting (merge window)

2012-03-23 Thread David Teigland
on i386: ERROR: sctp_do_peeloff [fs/dlm/dlm.ko] undefined! GFS2_FS selects DLM (if GFS2_FS_LOCKING_DLM, which is enabled). GFS2_FS selects IP_SCTP if DLM_SCTP, which is not enabled and not used anywhere else in the kernel tree AFAICT. DLM just always selects IP_SCTP. Here's what we have

Re: [Cluster-devel] GFS2: Pre-pull patch posting (merge window)

2012-03-23 Thread David Miller
From: David Teigland teigl...@redhat.com Date: Fri, 23 Mar 2012 15:41:52 -0400 Why does gfs2 Kconfig bother with SCTP at all? It seems that line should just be removed. I'll also remove EXPERIMENTAL. I don't understand the vagaries of Kconfig, so a dumb question, how could sctp_do_peeloff

Re: [Cluster-devel] GFS2: Pre-pull patch posting (merge window)

2012-03-23 Thread Steven Whitehouse
Hi, On Fri, 2012-03-23 at 13:06 -0700, Randy Dunlap wrote: On 03/23/2012 12:41 PM, David Teigland wrote: on i386: ERROR: sctp_do_peeloff [fs/dlm/dlm.ko] undefined! GFS2_FS selects DLM (if GFS2_FS_LOCKING_DLM, which is enabled). GFS2_FS selects IP_SCTP if DLM_SCTP, which is not

Re: [Cluster-devel] GFS2: Pre-pull patch posting (merge window)

2012-03-23 Thread David Teigland
On Fri, Mar 23, 2012 at 01:06:05PM -0700, Randy Dunlap wrote: GFS2_FS selects DLM (if GFS2_FS_LOCKING_DLM, which is enabled). GFS2_FS selects IP_SCTP if DLM_SCTP, which is not enabled and not used anywhere else in the kernel tree AFAICT. DLM just always selects IP_SCTP. Here's what we